Re: [Qemu-devel] [PATCH v2 03/14] sm501: QOMify

2017-03-02 Thread Peter Maydell
On 3 December 2016 at 02:05, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan It would be helpful to mention in the commit message that we don't yet implement reset or vmstate and that those are coming in a later commit. (There is almost always something useful to say in a commit message b

[Qemu-devel] [PATCH v2 03/14] sm501: QOMify

2017-02-25 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- v2: Add memory regions to device state instead of allocating them hw/display/sm501.c | 139 +++ hw/sh4/r2d.c | 11 +++- include/hw/devices.h | 5 -- 3 files changed, 106 insertions(+), 49 deletions(-)