Re: [Qemu-devel] [PATCH v2 03/15] migration: No need to take rcu during sync_dirty_bitmap

2019-05-20 Thread Peter Xu
On Mon, May 20, 2019 at 12:48:01PM +0200, Paolo Bonzini wrote: > On 20/05/19 05:08, Peter Xu wrote: > > cpu_physical_memory_sync_dirty_bitmap() has one RAMBlock* as > > parameter, which means that it must be with RCU read lock held > > already. Taking it again inside seems redundant. Removing it.

Re: [Qemu-devel] [PATCH v2 03/15] migration: No need to take rcu during sync_dirty_bitmap

2019-05-20 Thread Paolo Bonzini
On 20/05/19 05:08, Peter Xu wrote: > cpu_physical_memory_sync_dirty_bitmap() has one RAMBlock* as > parameter, which means that it must be with RCU read lock held > already. Taking it again inside seems redundant. Removing it. > Instead comment on the functions about the RCU read lock. > > Revie

[Qemu-devel] [PATCH v2 03/15] migration: No need to take rcu during sync_dirty_bitmap

2019-05-19 Thread Peter Xu
cpu_physical_memory_sync_dirty_bitmap() has one RAMBlock* as parameter, which means that it must be with RCU read lock held already. Taking it again inside seems redundant. Removing it. Instead comment on the functions about the RCU read lock. Reviewed-by: Paolo Bonzini Signed-off-by: Peter Xu