Re: [Qemu-devel] [PATCH v2 03/18] cutils: Add qemu_strdup_hexlify() and qemu_strdup_unhexlify()

2019-03-12 Thread Laszlo Ersek
On 03/09/19 15:32, Markus Armbruster wrote: > Laszlo Ersek writes: >> (5) Most importantly: I don't think we need this patch. >> >> First, AFAICS, the unhex function is never used in the series, and no >> unit test is being added for it. That makes it a bad candidate for >> "include/qemu/cutils.h

Re: [Qemu-devel] [PATCH v2 03/18] cutils: Add qemu_strdup_hexlify() and qemu_strdup_unhexlify()

2019-03-09 Thread Markus Armbruster
Laszlo Ersek writes: > Hi Phil, > > most important comment at the bottom. > > On 03/08/19 02:32, Philippe Mathieu-Daudé wrote: >> Add two helpers: one to represent a binary data as a string of >> hexadecimal values, and one to restore a such string into its >> original binary data. >> >> Signed-

Re: [Qemu-devel] [PATCH v2 03/18] cutils: Add qemu_strdup_hexlify() and qemu_strdup_unhexlify()

2019-03-08 Thread Laszlo Ersek
Hi Phil, most important comment at the bottom. On 03/08/19 02:32, Philippe Mathieu-Daudé wrote: > Add two helpers: one to represent a binary data as a string of > hexadecimal values, and one to restore a such string into its > original binary data. > > Signed-off-by: Philippe Mathieu-Daudé > --

[Qemu-devel] [PATCH v2 03/18] cutils: Add qemu_strdup_hexlify() and qemu_strdup_unhexlify()

2019-03-07 Thread Philippe Mathieu-Daudé
Add two helpers: one to represent a binary data as a string of hexadecimal values, and one to restore a such string into its original binary data. Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/cutils.h | 33 ++ util/cutils.c | 55 +