Re: [Qemu-devel] [PATCH v2 04/15] nvdimm: support nvdimm label

2016-06-28 Thread Stefan Hajnoczi
On Tue, Jun 28, 2016 at 09:48:10AM +0200, Paolo Bonzini wrote: > > > On 20/05/2016 10:20, Xiao Guangrong wrote: > > +if (size <= nvdimm->label_size) { > > +HostMemoryBackend *hostmem = dimm->hostmem; > > +char *path = object_get_canonical_path_component(OBJECT(hostmem)); > >

Re: [Qemu-devel] [PATCH v2 04/15] nvdimm: support nvdimm label

2016-06-28 Thread Paolo Bonzini
On 20/05/2016 10:20, Xiao Guangrong wrote: > +if (size <= nvdimm->label_size) { > +HostMemoryBackend *hostmem = dimm->hostmem; > +char *path = object_get_canonical_path_component(OBJECT(hostmem)); > + > +error_setg(errp, "the size of memdev %s (0x%" PRIx64 ") is too"

Re: [Qemu-devel] [PATCH v2 04/15] nvdimm: support nvdimm label

2016-05-30 Thread Stefan Hajnoczi
On Fri, May 20, 2016 at 04:20:01PM +0800, Xiao Guangrong wrote: > Introduce a parameter, 'label-size', which is the size of nvdimm label > data area which is reserved at the end of backend memory. It is required > at least 128k > > Two callbacks, read_label_data() and write_label_data(), are used

[Qemu-devel] [PATCH v2 04/15] nvdimm: support nvdimm label

2016-05-20 Thread Xiao Guangrong
Introduce a parameter, 'label-size', which is the size of nvdimm label data area which is reserved at the end of backend memory. It is required at least 128k Two callbacks, read_label_data() and write_label_data(), are used to operate the label area Signed-off-by: Xiao Guangrong