Re: [Qemu-devel] [PATCH v2 05/10] qemu.py: Use custom exceptions rather than Exception

2017-07-26 Thread Eduardo Habkost
On Wed, Jul 26, 2017 at 06:39:28AM +0200, Lukáš Doktor wrote: > Dne 25.7.2017 v 18:06 Eduardo Habkost napsal(a): > > On Tue, Jul 25, 2017 at 05:09:46PM +0200, Lukáš Doktor wrote: > >> The naked Exception should not be widely used. It makes sense to be a > >> bit more specific and use better-suited

Re: [Qemu-devel] [PATCH v2 05/10] qemu.py: Use custom exceptions rather than Exception

2017-07-25 Thread Lukáš Doktor
Dne 25.7.2017 v 18:06 Eduardo Habkost napsal(a): > On Tue, Jul 25, 2017 at 05:09:46PM +0200, Lukáš Doktor wrote: >> The naked Exception should not be widely used. It makes sense to be a >> bit more specific and use better-suited custom exceptions. As a benefit >> we can store the full reply in the

Re: [Qemu-devel] [PATCH v2 05/10] qemu.py: Use custom exceptions rather than Exception

2017-07-25 Thread Eduardo Habkost
On Tue, Jul 25, 2017 at 05:09:46PM +0200, Lukáš Doktor wrote: > The naked Exception should not be widely used. It makes sense to be a > bit more specific and use better-suited custom exceptions. As a benefit > we can store the full reply in the exception in case someone needs it > when catching the

[Qemu-devel] [PATCH v2 05/10] qemu.py: Use custom exceptions rather than Exception

2017-07-25 Thread Lukáš Doktor
The naked Exception should not be widely used. It makes sense to be a bit more specific and use better-suited custom exceptions. As a benefit we can store the full reply in the exception in case someone needs it when catching the exception. Signed-off-by: Lukáš Doktor Reviewed-by: Eduardo Habkost