Re: [Qemu-devel] [PATCH v2 05/39] fdsets: use weak aliases instead of qemu-tool.c/qemu-user.c

2012-11-16 Thread Paolo Bonzini
Il 15/11/2012 23:18, Stefan Weil ha scritto: Am 15.11.2012 21:52, schrieb Paolo Bonzini: Il 15/11/2012 19:01, Stefan Weil ha scritto: Hi Paolo, this patch breaks QEMU on 32 and 64 bit hosts, native and with Wine. It's easy to reproduce the SIGSEGV crash: just add a -snapshot option.

Re: [Qemu-devel] [PATCH v2 05/39] fdsets: use weak aliases instead of qemu-tool.c/qemu-user.c

2012-11-16 Thread Stefan Weil
Am 16.11.2012 10:35, schrieb Paolo Bonzini: Il 15/11/2012 23:18, Stefan Weil ha scritto: Am 15.11.2012 21:52, schrieb Paolo Bonzini: Il 15/11/2012 19:01, Stefan Weil ha scritto: Hi Paolo, this patch breaks QEMU on 32 and 64 bit hosts, native and with Wine. It's easy to reproduce the SIGSEGV

Re: [Qemu-devel] [PATCH v2 05/39] fdsets: use weak aliases instead of qemu-tool.c/qemu-user.c

2012-11-16 Thread Paolo Bonzini
Il 16/11/2012 18:15, Stefan Weil ha scritto: Tested-by: Stefan Weil s...@weilnetz.de Great, the above patch fixes w32/w64 (native and with Wine). Is this modification needed / does it work with MacOS X, too? Yes, but I found a way to get rid of weak references completely. The testing is

Re: [Qemu-devel] [PATCH v2 05/39] fdsets: use weak aliases instead of qemu-tool.c/qemu-user.c

2012-11-16 Thread Peter Maydell
On 16 November 2012 09:35, Paolo Bonzini pbonz...@redhat.com wrote: Ok, I reproduced the original binutils bug, and found a typo in the weakrefs implementation. Does this work for you? diff --git a/compiler.h b/compiler.h index 55d7d74..d552757 100644 --- a/compiler.h +++ b/compiler.h @@

Re: [Qemu-devel] [PATCH v2 05/39] fdsets: use weak aliases instead of qemu-tool.c/qemu-user.c

2012-11-16 Thread Paolo Bonzini
Il 16/11/2012 18:52, Peter Maydell ha scritto: clang: error: linker command failed with exit code 1 (use -v to see invocation) (clang builds OK with current git master.) But I have no idea why, or whether the generated code is correct... Looks like the safest bet is to go with the good old

Re: [Qemu-devel] [PATCH v2 05/39] fdsets: use weak aliases instead of qemu-tool.c/qemu-user.c

2012-11-15 Thread Stefan Weil
Am 31.10.2012 16:30, schrieb Paolo Bonzini: Signed-off-by: Paolo Bonzinipbonz...@redhat.com --- cutils.c | 5 - osdep.c | 30 ++ qemu-common.h | 1 - qemu-tool.c | 20 qemu-user.c | 20 5 file

Re: [Qemu-devel] [PATCH v2 05/39] fdsets: use weak aliases instead of qemu-tool.c/qemu-user.c

2012-11-15 Thread Paolo Bonzini
Il 15/11/2012 19:01, Stefan Weil ha scritto: Hi Paolo, this patch breaks QEMU on 32 and 64 bit hosts, native and with Wine. It's easy to reproduce the SIGSEGV crash: just add a -snapshot option. Obviously the critical code is executed only when this option was used. I cannot reproduce this,

Re: [Qemu-devel] [PATCH v2 05/39] fdsets: use weak aliases instead of qemu-tool.c/qemu-user.c

2012-11-15 Thread Stefan Weil
Am 15.11.2012 21:52, schrieb Paolo Bonzini: Il 15/11/2012 19:01, Stefan Weil ha scritto: Hi Paolo, this patch breaks QEMU on 32 and 64 bit hosts, native and with Wine. It's easy to reproduce the SIGSEGV crash: just add a -snapshot option. Obviously the critical code is executed only when this

[Qemu-devel] [PATCH v2 05/39] fdsets: use weak aliases instead of qemu-tool.c/qemu-user.c

2012-10-31 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cutils.c | 5 - osdep.c | 30 ++ qemu-common.h | 1 - qemu-tool.c | 20 qemu-user.c | 20 5 file modificati, 30 inserzioni(+), 46 rimozioni(-) diff