Re: [Qemu-devel] [PATCH v2 06/23] block: Make BlockBackend own its BlockDriverState

2014-09-16 Thread Markus Armbruster
Benoît Canet writes: >> /* blkdev->bs is not create by us, we get a reference >> * so we can bdrv_unref() unconditionally */ >> -bdrv_ref(blkdev->bs); > >> +/* Except we don't bdrv_unref() anymore, we blk_unref(). > Is this dot extra ?

Re: [Qemu-devel] [PATCH v2 06/23] block: Make BlockBackend own its BlockDriverState

2014-09-16 Thread Benoît Canet
> /* blkdev->bs is not create by us, we get a reference > * so we can bdrv_unref() unconditionally */ > -bdrv_ref(blkdev->bs); > +/* Except we don't bdrv_unref() anymore, we blk_unref(). Is this dot extra ? ^ The foll

[Qemu-devel] [PATCH v2 06/23] block: Make BlockBackend own its BlockDriverState

2014-09-13 Thread Markus Armbruster
On BlockBackend destruction, unref its BlockDriverState. Replaces the callers' unrefs. Signed-off-by: Markus Armbruster --- block/block-backend.c | 6 ++ blockdev.c| 7 ++- hw/block/xen_disk.c | 6 +++--- qemu-img.c| 35 +-- q