Re: [Qemu-devel] [PATCH v2 07/10] target-mips: kvm: Add main KVM support for MIPS

2014-02-11 Thread James Hogan
Hi Andreas, On 10/02/14 14:07, Andreas Färber wrote: +#define dprintf(fmt, ...) \ dprintf is the name of a stdio.h function, so DPRINTF may be a better name. Okay. +int kvm_arch_init_vcpu(CPUState *env) Please use env only for CPUMIPSState, use cpu or cs here. The usual convention is

Re: [Qemu-devel] [PATCH v2 07/10] target-mips: kvm: Add main KVM support for MIPS

2014-02-10 Thread Andreas Färber
Am 16.12.2013 15:12, schrieb James Hogan: From: Sanjay Lal sanj...@kymasys.com Implement the main KVM arch API for MIPS. Signed-off-by: Sanjay Lal sanj...@kymasys.com Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Aurelien Jarno aurel...@aurel32.net Cc: Gleb Natapov

Re: [Qemu-devel] [PATCH v2 07/10] target-mips: kvm: Add main KVM support for MIPS

2013-12-21 Thread Aurelien Jarno
On Mon, Dec 16, 2013 at 02:12:42PM +, James Hogan wrote: From: Sanjay Lal sanj...@kymasys.com Implement the main KVM arch API for MIPS. Signed-off-by: Sanjay Lal sanj...@kymasys.com Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Aurelien Jarno aurel...@aurel32.net Cc: Gleb

[Qemu-devel] [PATCH v2 07/10] target-mips: kvm: Add main KVM support for MIPS

2013-12-16 Thread James Hogan
From: Sanjay Lal sanj...@kymasys.com Implement the main KVM arch API for MIPS. Signed-off-by: Sanjay Lal sanj...@kymasys.com Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Aurelien Jarno aurel...@aurel32.net Cc: Gleb Natapov g...@redhat.com Cc: Paolo Bonzini pbonz...@redhat.com ---