Re: [Qemu-devel] [PATCH v2 07/14] acpi: Remove guest_info parameters from functions

2015-12-18 Thread Eduardo Habkost
On Tue, Dec 15, 2015 at 02:36:10PM +0200, Marcel Apfelbaum wrote: > On 12/11/2015 08:42 PM, Eduardo Habkost wrote: > >We can use PC_MACHINE(qdev_get_machine())->acpi_guest_info to get > >guest_info. > > Hi Eduardo, > > I like the idea of using qdev_get_machine() to get the machine instead of >

Re: [Qemu-devel] [PATCH v2 07/14] acpi: Remove guest_info parameters from functions

2015-12-18 Thread Marcel Apfelbaum
On 12/18/2015 08:08 PM, Eduardo Habkost wrote: On Tue, Dec 15, 2015 at 02:36:10PM +0200, Marcel Apfelbaum wrote: On 12/11/2015 08:42 PM, Eduardo Habkost wrote: We can use PC_MACHINE(qdev_get_machine())->acpi_guest_info to get guest_info. Hi Eduardo, I like the idea of using

Re: [Qemu-devel] [PATCH v2 07/14] acpi: Remove guest_info parameters from functions

2015-12-15 Thread Marcel Apfelbaum
On 12/11/2015 08:42 PM, Eduardo Habkost wrote: We can use PC_MACHINE(qdev_get_machine())->acpi_guest_info to get guest_info. Hi Eduardo, I like the idea of using qdev_get_machine() to get the machine instead of keeping the reference around, however only in places we cannot get a reference to

[Qemu-devel] [PATCH v2 07/14] acpi: Remove guest_info parameters from functions

2015-12-11 Thread Eduardo Habkost
We can use PC_MACHINE(qdev_get_machine())->acpi_guest_info to get guest_info. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 35 +-- hw/i386/acpi-build.h | 2 +- hw/i386/pc.c | 2 +- 3 files changed, 23 insertions(+), 16