Re: [Qemu-devel] [PATCH v2 08/13] block: Allow changing the backing file on reopen

2019-03-12 Thread Alberto Garcia
On Tue 12 Mar 2019 01:20:54 PM CET, Kevin Wolf wrote: >> +reopen_state->replace_backing_bs = true; >> +reopen_state->new_backing_bs = new_backing_bs; > > Do we need to bdrv_ref(new_backing_bs) here in case its only reference > is dropped in the same reopen transaction? I'm not sure

Re: [Qemu-devel] [PATCH v2 08/13] block: Allow changing the backing file on reopen

2019-03-12 Thread Kevin Wolf
Am 06.03.2019 um 19:11 hat Alberto Garcia geschrieben: > This patch allows the user to change the backing file of an image that > is being reopened. Here's what it does: > > - In bdrv_reopen_prepare(): check that the value of 'backing' points >to an existing node or is null. If it points to a

[Qemu-devel] [PATCH v2 08/13] block: Allow changing the backing file on reopen

2019-03-06 Thread Alberto Garcia
This patch allows the user to change the backing file of an image that is being reopened. Here's what it does: - In bdrv_reopen_prepare(): check that the value of 'backing' points to an existing node or is null. If it points to an existing node it also needs to make sure that replacing the