Re: [Qemu-devel] [PATCH v2 08/16] linux-user: respect timezone for settimeofday

2014-06-22 Thread Paul Burton
On Sun, Jun 22, 2014 at 12:18:02AM +0100, Peter Maydell wrote: > > +if (!lock_user_struct(VERIFY_READ, target_tz, target_tz_addr, 1)) > > +return -TARGET_EFAULT; > > Coding style mandates braces even on single-line if()s; checkpatch.pl > will catch this usually. I copied that style fr

Re: [Qemu-devel] [PATCH v2 08/16] linux-user: respect timezone for settimeofday

2014-06-21 Thread Peter Maydell
On 21 June 2014 23:53, Paul Burton wrote: > The settimeofday syscall accepts a tz argument indicating the desired > timezone to the kernel. QEMU previously ignored any argument provided > by the target program & always passed NULL to the kernel. Instead, > translate the argument & pass along the d

[Qemu-devel] [PATCH v2 08/16] linux-user: respect timezone for settimeofday

2014-06-21 Thread Paul Burton
The settimeofday syscall accepts a tz argument indicating the desired timezone to the kernel. QEMU previously ignored any argument provided by the target program & always passed NULL to the kernel. Instead, translate the argument & pass along the data userland provided. Although this argument is d