Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call() to interrupt.c

2017-09-05 Thread Cornelia Huck
On Tue, 5 Sep 2017 14:52:44 +0200 Thomas Huth wrote: > On 05.09.2017 14:46, Christian Borntraeger wrote: > > > > > > On 09/05/2017 02:42 PM, David Hildenbrand wrote: > >> On 05.09.2017 14:38, Cornelia Huck wrote: > >>> On Mon, 4 Sep 2017 17:43:05 +0200 > >>> David Hildenbrand wrote: > >>>

Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call() to interrupt.c

2017-09-05 Thread Thomas Huth
On 05.09.2017 14:46, Christian Borntraeger wrote: > > > On 09/05/2017 02:42 PM, David Hildenbrand wrote: >> On 05.09.2017 14:38, Cornelia Huck wrote: >>> On Mon, 4 Sep 2017 17:43:05 +0200 >>> David Hildenbrand wrote: >>> Fix up includes and rename it to s390x_*. >>> >>> I'm not quite sure

Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call() to interrupt.c

2017-09-05 Thread Christian Borntraeger
On 09/05/2017 02:42 PM, David Hildenbrand wrote: > On 05.09.2017 14:38, Cornelia Huck wrote: >> On Mon, 4 Sep 2017 17:43:05 +0200 >> David Hildenbrand wrote: >> >>> Fix up includes and rename it to s390x_*. >> >> I'm not quite sure whether that is the right direction: servc is just an >> instru

Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call() to interrupt.c

2017-09-05 Thread David Hildenbrand
On 05.09.2017 14:38, Cornelia Huck wrote: > On Mon, 4 Sep 2017 17:43:05 +0200 > David Hildenbrand wrote: > >> Fix up includes and rename it to s390x_*. > > I'm not quite sure whether that is the right direction: servc is just an > instruction that does something and then happens to also generat

Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call() to interrupt.c

2017-09-05 Thread Cornelia Huck
On Mon, 4 Sep 2017 17:43:05 +0200 David Hildenbrand wrote: > Fix up includes and rename it to s390x_*. I'm not quite sure whether that is the right direction: servc is just an instruction that does something and then happens to also generate an interrupt on conclusion. I'll think a bit more abo

[Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call() to interrupt.c

2017-09-04 Thread David Hildenbrand
Fix up includes and rename it to s390x_*. cpu.h is now free of externally implemented functions. Signed-off-by: David Hildenbrand --- hw/s390x/sclp.c| 51 +- include/hw/s390x/sclp.h| 1 + target/s390x/cpu.h | 5 + target/s