Re: [Qemu-devel] [PATCH v2 09/14] target/sh4: optimize gen_store_fpr64

2017-05-10 Thread Philippe Mathieu-Daudé
On 05/09/2017 06:09 PM, Richard Henderson wrote: On 05/06/2017 04:14 AM, Aurelien Jarno wrote: +tcg_gen_extrl_i64_i32(cpu_fregs[reg + 1], t); +tcg_gen_extrh_i64_i32(cpu_fregs[reg], t); This is tcg_gen_extr_i64_i32(cpu_fregs[reg + 1], cpu_fregs[reg], t); nicer :) Otherwise,

Re: [Qemu-devel] [PATCH v2 09/14] target/sh4: optimize gen_store_fpr64

2017-05-10 Thread Aurelien Jarno
On 2017-05-09 14:09, Richard Henderson wrote: > On 05/06/2017 04:14 AM, Aurelien Jarno wrote: > > +tcg_gen_extrl_i64_i32(cpu_fregs[reg + 1], t); > > +tcg_gen_extrh_i64_i32(cpu_fregs[reg], t); > > This is > > tcg_gen_extr_i64_i32(cpu_fregs[reg + 1], cpu_fregs[reg], t); > Good catch,

Re: [Qemu-devel] [PATCH v2 09/14] target/sh4: optimize gen_store_fpr64

2017-05-09 Thread Richard Henderson
On 05/06/2017 04:14 AM, Aurelien Jarno wrote: +tcg_gen_extrl_i64_i32(cpu_fregs[reg + 1], t); +tcg_gen_extrh_i64_i32(cpu_fregs[reg], t); This is tcg_gen_extr_i64_i32(cpu_fregs[reg + 1], cpu_fregs[reg], t); Otherwise, Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH v2 09/14] target/sh4: optimize gen_store_fpr64

2017-05-06 Thread Aurelien Jarno
Isuing extrh and avoiding intermediate temps. Signed-off-by: Aurelien Jarno --- target/sh4/translate.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index a4c7a0895b..b4e5606098 100644 ---