Re: [Qemu-devel] [PATCH v2 09/22] nbd/client: Refactor nbd_receive_list()

2018-12-19 Thread Vladimir Sementsov-Ogievskiy
15.12.2018 16:53, Eric Blake wrote: > Right now, nbd_receive_list() is only called by > nbd_receive_query_exports(), which in turn is only called if the > server lacks NBD_OPT_GO but has working option negotiation, and is > merely used as a quality-of-implementation trick since servers > can't give

Re: [Qemu-devel] [PATCH v2 09/22] nbd/client: Refactor nbd_receive_list()

2018-12-15 Thread Richard W.M. Jones
On Sat, Dec 15, 2018 at 07:53:11AM -0600, Eric Blake wrote: > Right now, nbd_receive_list() is only called by > nbd_receive_query_exports(), which in turn is only called if the > server lacks NBD_OPT_GO but has working option negotiation, and is > merely used as a quality-of-implementation trick si

[Qemu-devel] [PATCH v2 09/22] nbd/client: Refactor nbd_receive_list()

2018-12-15 Thread Eric Blake
Right now, nbd_receive_list() is only called by nbd_receive_query_exports(), which in turn is only called if the server lacks NBD_OPT_GO but has working option negotiation, and is merely used as a quality-of-implementation trick since servers can't give decent errors for NBD_OPT_EXPORT_NAME. Howev