Re: [Qemu-devel] [PATCH v2 09/45] block: rename block_job_complete to block_job_completed

2012-09-28 Thread Paolo Bonzini
Il 27/09/2012 22:31, Jeff Cody ha scritto: block_job_completed(): cleans up when a job is done It also raises a BLOCK_JOB_COMPLETED event. block_job_complete(): requests that a block job be completed How about renaming both of them, respectively, to: block_job_cleanup(): cleans up

Re: [Qemu-devel] [PATCH v2 09/45] block: rename block_job_complete to block_job_completed

2012-09-27 Thread Kevin Wolf
Am 26.09.2012 17:56, schrieb Paolo Bonzini: The imperative will be used for the QMP command. Signed-off-by: Paolo Bonzini pbonz...@redhat.com I would still be glad if we found a better name. Having two functions block_job_complete() and block_job_completed() sounds like a great source for

Re: [Qemu-devel] [PATCH v2 09/45] block: rename block_job_complete to block_job_completed

2012-09-27 Thread Jeff Cody
On 09/27/2012 08:30 AM, Kevin Wolf wrote: Am 26.09.2012 17:56, schrieb Paolo Bonzini: The imperative will be used for the QMP command. Signed-off-by: Paolo Bonzini pbonz...@redhat.com I would still be glad if we found a better name. Having two functions block_job_complete() and

[Qemu-devel] [PATCH v2 09/45] block: rename block_job_complete to block_job_completed

2012-09-26 Thread Paolo Bonzini
The imperative will be used for the QMP command. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/stream.c | 4 ++-- blockjob.c | 2 +- blockjob.h | 4 ++-- 3 file modificati, 5 inserzioni(+), 5 rimozioni(-) diff --git a/block/stream.c b/block/stream.c index 57e4be7..a8f585a