Re: [Qemu-devel] [PATCH v2 1/1] block: clarify error message for qmp-eject

2016-05-30 Thread Markus Armbruster
John Snow writes: > It already got applied, but I can change it to your preference. (Always > return an -errno and an Error, delete-and-free when we don't care about > it...) I think that would be an improvement. This is advice, not a demand :)

Re: [Qemu-devel] [PATCH v2 1/1] block: clarify error message for qmp-eject

2016-05-20 Thread John Snow
On 05/20/2016 10:48 AM, Markus Armbruster wrote: > John Snow writes: > >> If you use HMP's eject but the CDROM tray is locked, you may get a >> confusing error message informing you that the "tray isn't open." >> >> As this is the point of eject, we can do a little better and help >> clarify th

Re: [Qemu-devel] [PATCH v2 1/1] block: clarify error message for qmp-eject

2016-05-20 Thread Markus Armbruster
John Snow writes: > If you use HMP's eject but the CDROM tray is locked, you may get a > confusing error message informing you that the "tray isn't open." > > As this is the point of eject, we can do a little better and help > clarify that the tray was locked and that it (might) open up later, >

Re: [Qemu-devel] [PATCH v2 1/1] block: clarify error message for qmp-eject

2016-05-18 Thread Fam Zheng
On Wed, 05/18 17:53, John Snow wrote: > If you use HMP's eject but the CDROM tray is locked, you may get a > confusing error message informing you that the "tray isn't open." > > As this is the point of eject, we can do a little better and help > clarify that the tray was locked and that it (might

Re: [Qemu-devel] [PATCH v2 1/1] block: clarify error message for qmp-eject

2016-05-18 Thread Eric Blake
On 05/18/2016 03:53 PM, John Snow wrote: > If you use HMP's eject but the CDROM tray is locked, you may get a > confusing error message informing you that the "tray isn't open." > > As this is the point of eject, we can do a little better and help > clarify that the tray was locked and that it (mi

[Qemu-devel] [PATCH v2 1/1] block: clarify error message for qmp-eject

2016-05-18 Thread John Snow
If you use HMP's eject but the CDROM tray is locked, you may get a confusing error message informing you that the "tray isn't open." As this is the point of eject, we can do a little better and help clarify that the tray was locked and that it (might) open up later, so try again. It's not ideal,