Re: [Qemu-devel] [PATCH v2 1/1] cpu: report hyperv feature words through qom

2016-06-24 Thread Eduardo Habkost
On Fri, Jun 24, 2016 at 01:10:45PM +0300, Evgeny Yakovlev wrote: [...] > Thanks for all the comments! > Removing hyperv_* booleans sounds like the proper way forward however it > will break compatibility with how libvirt enables hyperv enlightenments. It won't break any compatibility, if the prope

Re: [Qemu-devel] [PATCH v2 1/1] cpu: report hyperv feature words through qom

2016-06-24 Thread Evgeny Yakovlev
On 23.06.2016 00:01, Eduardo Habkost wrote: On Mon, Jun 20, 2016 at 06:29:40PM +0300, Denis V. Lunev wrote: From: Evgeny Yakovlev This change adds hyperv feature words report through qom rpc. When VM is configured with hyperv features enabled libvirt will check that required feature words ar

Re: [Qemu-devel] [PATCH v2 1/1] cpu: report hyperv feature words through qom

2016-06-22 Thread Eduardo Habkost
On Tue, Jun 21, 2016 at 02:00:22PM +0200, Paolo Bonzini wrote: > On 20/06/2016 17:29, Denis V. Lunev wrote: > > +static int hyperv_handle_properties(CPUState *cs) > > +{ > > +X86CPU *cpu = X86_CPU(cs); > > +CPUX86State *env = &cpu->env; > > + > > +if (cpu->hyperv_relaxed_timing) { > > +

Re: [Qemu-devel] [PATCH v2 1/1] cpu: report hyperv feature words through qom

2016-06-22 Thread Eduardo Habkost
On Mon, Jun 20, 2016 at 06:29:40PM +0300, Denis V. Lunev wrote: > From: Evgeny Yakovlev > > This change adds hyperv feature words report through qom rpc. > > When VM is configured with hyperv features enabled > libvirt will check that required feature words are set > in cpuid leaf 4003 throu

Re: [Qemu-devel] [PATCH v2 1/1] cpu: report hyperv feature words through qom

2016-06-21 Thread Paolo Bonzini
On 20/06/2016 17:29, Denis V. Lunev wrote: > +static int hyperv_handle_properties(CPUState *cs) > +{ > +X86CPU *cpu = X86_CPU(cs); > +CPUX86State *env = &cpu->env; > + > +if (cpu->hyperv_relaxed_timing) { > +env->features[FEAT_HYPERV_EAX] |= HV_X64_MSR_HYPERCALL_AVAILABLE; > +

[Qemu-devel] [PATCH v2 1/1] cpu: report hyperv feature words through qom

2016-06-20 Thread Denis V. Lunev
From: Evgeny Yakovlev This change adds hyperv feature words report through qom rpc. When VM is configured with hyperv features enabled libvirt will check that required feature words are set in cpuid leaf 4003 through qom request. Currently qemu does not report hyperv feature words which pre