Re: [Qemu-devel] [PATCH v2 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1.

2014-08-27 Thread Andrey Korolyov
On Wed, Aug 27, 2014 at 12:39 PM, tangchen wrote: > > On 08/26/2014 10:24 PM, Andrey Korolyov wrote: >> >> .. >> >> Just to remind - Windows will not add pc dimms without populated SRAT, >> so imho forcing NUMA topology to be set (and whose support is required >> anyway from guest linux kernel

Re: [Qemu-devel] [PATCH v2 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1.

2014-08-27 Thread tangchen
On 08/26/2014 10:24 PM, Andrey Korolyov wrote: .. Just to remind - Windows will not add pc dimms without populated SRAT, so imho forcing NUMA topology to be set (and whose support is required anyway from guest linux kernel in order to support ACPI hotplug) is better than approach proposed by

Re: [Qemu-devel] [PATCH v2 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1.

2014-08-27 Thread tangchen
On 08/26/2014 10:24 PM, Andrey Korolyov wrote: .. Just to remind - Windows will not add pc dimms without populated SRAT, so imho forcing NUMA topology to be set (and whose support is required anyway from guest linux kernel in order to support ACPI hotplug) is better than approach proposed by

Re: [Qemu-devel] [PATCH v2 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1.

2014-08-26 Thread Andrey Korolyov
On Tue, Aug 26, 2014 at 1:32 PM, tangchen wrote: > Hi , > > Would anybody help to review this patch ? > > Thanks. :) > > > On 08/19/2014 09:55 AM, Tang Chen wrote: >> >> If user doesn't specify numa options, nb_numa_nodes will be 0. But >> PCDIMMDevice->node >> is also initialized to 0. As a resul

Re: [Qemu-devel] [PATCH v2 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1.

2014-08-26 Thread tangchen
Hi , Would anybody help to review this patch ? Thanks. :) On 08/19/2014 09:55 AM, Tang Chen wrote: If user doesn't specify numa options, nb_numa_nodes will be 0. But PCDIMMDevice->node is also initialized to 0. As a result, the following check will fail: pc_dimm_realize() { ..

[Qemu-devel] [PATCH v2 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1.

2014-08-18 Thread Tang Chen
If user doesn't specify numa options, nb_numa_nodes will be 0. But PCDIMMDevice->node is also initialized to 0. As a result, the following check will fail: pc_dimm_realize() { .. if (dimm->node >= nb_numa_nodes) { error_setg(errp, "'DIMM property " PC_DIMM_NODE_PRO