Re: [Qemu-devel] [PATCH v2 1/1] virtio: serial: expose a 'guest_writable' callback for users

2014-10-10 Thread Amit Shah
On (Fri) 10 Oct 2014 [12:23:21], Peter Maydell wrote: > On 10 October 2014 12:19, Amit Shah wrote: > > On (Thu) 09 Oct 2014 [14:04:53], Peter Maydell wrote: > >> What I would like to see in this patch is a comment giving > >> much clearer definition of the semantics of the guest_writable > >> call

Re: [Qemu-devel] [PATCH v2 1/1] virtio: serial: expose a 'guest_writable' callback for users

2014-10-10 Thread Peter Maydell
On 10 October 2014 12:19, Amit Shah wrote: > On (Thu) 09 Oct 2014 [14:04:53], Peter Maydell wrote: >> What I would like to see in this patch is a comment giving >> much clearer definition of the semantics of the guest_writable >> call: for instance, is it always called when the guest is >> writabl

Re: [Qemu-devel] [PATCH v2 1/1] virtio: serial: expose a 'guest_writable' callback for users

2014-10-10 Thread Amit Shah
On (Thu) 09 Oct 2014 [14:04:53], Peter Maydell wrote: > On 9 October 2014 13:17, Amit Shah wrote: > > On (Thu) 09 Oct 2014 [13:18:16], Markus Armbruster wrote: > >> The code should work, but whether it makes sense is hard to judge for > >> virtio noobs like me without a user of guest_writable. Th

Re: [Qemu-devel] [PATCH v2 1/1] virtio: serial: expose a 'guest_writable' callback for users

2014-10-09 Thread Peter Maydell
On 9 October 2014 13:17, Amit Shah wrote: > On (Thu) 09 Oct 2014 [13:18:16], Markus Armbruster wrote: >> The code should work, but whether it makes sense is hard to judge for >> virtio noobs like me without a user of guest_writable. The conditional >> guarding vsc->guest_writable(port) in particu

Re: [Qemu-devel] [PATCH v2 1/1] virtio: serial: expose a 'guest_writable' callback for users

2014-10-09 Thread Amit Shah
On (Thu) 09 Oct 2014 [13:18:16], Markus Armbruster wrote: > Amit Shah writes: > > > Users of virtio-serial may want to know when a port becomes writable. A > > port can stop accepting writes if the guest port is open but not being > > read from. In this case, data gets queued up in the virtqueu

Re: [Qemu-devel] [PATCH v2 1/1] virtio: serial: expose a 'guest_writable' callback for users

2014-10-09 Thread Markus Armbruster
Amit Shah writes: > Users of virtio-serial may want to know when a port becomes writable. A > port can stop accepting writes if the guest port is open but not being > read from. In this case, data gets queued up in the virtqueue, and > after the vq is full, writes to the port do not succeed. >

[Qemu-devel] [PATCH v2 1/1] virtio: serial: expose a 'guest_writable' callback for users

2014-09-30 Thread Amit Shah
Users of virtio-serial may want to know when a port becomes writable. A port can stop accepting writes if the guest port is open but not being read from. In this case, data gets queued up in the virtqueue, and after the vq is full, writes to the port do not succeed. When the guest reads off a vq