Re: [Qemu-devel] [PATCH v2 1/2] target-arm: Fix handling of SDCR for 32-bit code

2016-02-22 Thread Alistair Francis
On Fri, Feb 19, 2016 at 6:39 AM, Peter Maydell wrote: > Fix two issues with our implementation of the SDCR: > * it is only present from ARMv8 onwards > * it does not contain several of the trap bits present in its 64-bit >counterpart the MDCR_EL3 > > Put the

Re: [Qemu-devel] [PATCH v2 1/2] target-arm: Fix handling of SDCR for 32-bit code

2016-02-19 Thread Peter Maydell
On 19 February 2016 at 16:31, Sergey Fedorov wrote: > On 19.02.2016 17:39, Peter Maydell wrote: >> +static void sdcr_write(CPUARMState *env, const ARMCPRegInfo *ri, >> + uint64_t value) >> +{ >> +env->cp15.mdcr_el3 = value & SDCR_VALID_MASK; >> +}

Re: [Qemu-devel] [PATCH v2 1/2] target-arm: Fix handling of SDCR for 32-bit code

2016-02-19 Thread Sergey Fedorov
On 19.02.2016 17:39, Peter Maydell wrote: > Fix two issues with our implementation of the SDCR: > * it is only present from ARMv8 onwards > * it does not contain several of the trap bits present in its 64-bit >counterpart the MDCR_EL3 > > Put the register description in the right place so

[Qemu-devel] [PATCH v2 1/2] target-arm: Fix handling of SDCR for 32-bit code

2016-02-19 Thread Peter Maydell
Fix two issues with our implementation of the SDCR: * it is only present from ARMv8 onwards * it does not contain several of the trap bits present in its 64-bit counterpart the MDCR_EL3 Put the register description in the right place so that it does not get enabled for ARMv7 and earlier, and