Re: [Qemu-devel] [PATCH v2 1/3] block: pass bdrv_* methods to bs->file by default

2017-07-03 Thread Eric Blake
On 07/03/2017 10:56 AM, Eric Blake wrote: > On 06/29/2017 01:43 PM, Manos Pitsidianakis wrote: >> The following functions fail if bs->drv does not implement them: One other suggestion: most patches in the tree use 'topic: Capital', while yours used 'topic: lowercase'. It's probably worth posting

Re: [Qemu-devel] [PATCH v2 1/3] block: pass bdrv_* methods to bs->file by default

2017-07-03 Thread Eric Blake
On 06/29/2017 01:43 PM, Manos Pitsidianakis wrote: > The following functions fail if bs->drv does not implement them: > > bdrv_probe_blocksizes > bdrv_probe_geometry > bdrv_truncate > bdrv_has_zero_init > bdrv_get_info > bdrv_media_changed > bdrv_eject > bdrv_lock_medium > bdrv_co_ioctl > > Inste

[Qemu-devel] [PATCH v2 1/3] block: pass bdrv_* methods to bs->file by default

2017-06-29 Thread Manos Pitsidianakis
The following functions fail if bs->drv does not implement them: bdrv_probe_blocksizes bdrv_probe_geometry bdrv_truncate bdrv_has_zero_init bdrv_get_info bdrv_media_changed bdrv_eject bdrv_lock_medium bdrv_co_ioctl Instead, the call should be passed to bs->file if it exists, to allow filter drive