Re: [Qemu-devel] [PATCH v2 1/3] error: don't rely on pointer comparisons

2015-06-18 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 06/17/2015 01:24 AM, Michael S. Tsirkin wrote: makes it possible to copy error_abort pointers, not just pass them on directly. @@ -168,7 +175,7 @@ void error_free(Error *err) void error_propagate(Error **dst_errp, Error *local_err) { -if

Re: [Qemu-devel] [PATCH v2 1/3] error: don't rely on pointer comparisons

2015-06-18 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: makes it possible to copy error_abort pointers, not just pass them on directly. Humor me, and start your sentences with a capital letter :) This is needed because follow-up patches add support for Error *local_err = ...; as a way to set an

[Qemu-devel] [PATCH v2 1/3] error: don't rely on pointer comparisons

2015-06-17 Thread Michael S. Tsirkin
makes it possible to copy error_abort pointers, not just pass them on directly. This is needed because follow-up patches add support for Error *local_err = ...; as a way to set an abort-on-error pointer, which requires that we have more than just a global error_abort abort-on-error pointer,

Re: [Qemu-devel] [PATCH v2 1/3] error: don't rely on pointer comparisons

2015-06-17 Thread Eric Blake
On 06/17/2015 01:24 AM, Michael S. Tsirkin wrote: makes it possible to copy error_abort pointers, not just pass them on directly. This is needed because follow-up patches add support for Error *local_err = ...; as a way to set an abort-on-error pointer, which requires that we have more

Re: [Qemu-devel] [PATCH v2 1/3] error: don't rely on pointer comparisons

2015-06-17 Thread Eric Blake
On 06/17/2015 01:24 AM, Michael S. Tsirkin wrote: makes it possible to copy error_abort pointers, not just pass them on directly. @@ -168,7 +175,7 @@ void error_free(Error *err) void error_propagate(Error **dst_errp, Error *local_err) { -if (local_err dst_errp == error_abort) {