[Qemu-devel] [PATCH v2 1/3] hw/pci: factor PCI reserve resources to a separate structure

2018-08-16 Thread Jing Liu
Factor "bus_reserve", "io_reserve", "mem_reserve", "pref32_reserve" and "pref64_reserve" fields of the "GenPCIERootPort" structure out to "PCIResReserve" structure, so that other PCI bridges can reuse it to add resource reserve capability. Signed-off-by: Jing Liu --- hw/pci-bridge/gen_pcie_root_

Re: [Qemu-devel] [PATCH v2 1/3] hw/pci: factor PCI reserve resources to a separate structure

2018-08-17 Thread Marcel Apfelbaum
Hi Jing, On 08/16/2018 12:28 PM, Jing Liu wrote: Factor "bus_reserve", "io_reserve", "mem_reserve", "pref32_reserve" and "pref64_reserve" fields of the "GenPCIERootPort" structure out to "PCIResReserve" structure, so that other PCI bridges can reuse it to add resource reserve capability. Signed

Re: [Qemu-devel] [PATCH v2 1/3] hw/pci: factor PCI reserve resources to a separate structure

2018-08-19 Thread Liu, Jing2
Hi Marcel, On 8/17/2018 11:49 PM, Marcel Apfelbaum wrote: Hi Jing, [...] +/* + * additional resources to reserve on firmware init + */ +typedef struct PCIResReserve { +    uint32_t bus_reserve; +    uint64_t io_reserve; +    uint64_t mem_reserve; The patch looks good to me, I noticed you re