Re: [Qemu-devel] [PATCH v2 1/3] qemu-tls.h: Add abstraction layer for TLS variables

2011-10-28 Thread Peter Maydell
On 28 October 2011 08:27, Markus Armbruster wrote: > Andreas Färber writes: > >> Am 27.10.2011 13:37, schrieb Peter Maydell: >>> + * Copyright (c) 2011 Red Hat, Inc, Linaro Limited >> >> The concatenation looks kind of funny. ;) > > I'd split into > >  * Copyright (c) 2011 Red Hat, Inc >  * Copyr

Re: [Qemu-devel] [PATCH v2 1/3] qemu-tls.h: Add abstraction layer for TLS variables

2011-10-28 Thread Markus Armbruster
Andreas Färber writes: > Am 27.10.2011 13:37, schrieb Peter Maydell: >> Add an abstraction layer for defining and using thread-local >> variables. For the moment this is implemented only for Linux, >> which means they can only be used in restricted circumstances. >> The abstraction layer allows u

Re: [Qemu-devel] [PATCH v2 1/3] qemu-tls.h: Add abstraction layer for TLS variables

2011-10-27 Thread Andreas Färber
Am 27.10.2011 17:04, schrieb Andreas Färber: > Am 27.10.2011 13:37, schrieb Peter Maydell: >> Add an abstraction layer for defining and using thread-local >> variables. For the moment this is implemented only for Linux, >> which means they can only be used in restricted circumstances. >> The abstra

Re: [Qemu-devel] [PATCH v2 1/3] qemu-tls.h: Add abstraction layer for TLS variables

2011-10-27 Thread Paolo Bonzini
On 10/27/2011 05:15 PM, Peter Maydell wrote: >> +#define DEFINE_TLS(type, x) __thread __typeof__(type) tls__##x > I assume __typeof__() is a GCCism, indicated by ..._GCC_H, to ensure > type is actually a valid type? Paolo? No, _GCC_H has nothing to do with GCCisms. __typeof__ is needed

Re: [Qemu-devel] [PATCH v2 1/3] qemu-tls.h: Add abstraction layer for TLS variables

2011-10-27 Thread Peter Maydell
On 27 October 2011 16:04, Andreas Färber wrote: >> + * Copyright (c) 2011 Red Hat, Inc, Linaro Limited > > The concatenation looks kind of funny. ;) Yeah, I know :-) Hope nobody in five years time goes looking for those Inc guys to try to track them down for a licensing change... >> +#ifndef QEM

Re: [Qemu-devel] [PATCH v2 1/3] qemu-tls.h: Add abstraction layer for TLS variables

2011-10-27 Thread Paolo Bonzini
On 10/27/2011 05:04 PM, Andreas Färber wrote: [Paolo's SoB missing] There's really 1-2 lines of my code left, but anyway Signed-off-by: Paolo Bonzini Paolo

Re: [Qemu-devel] [PATCH v2 1/3] qemu-tls.h: Add abstraction layer for TLS variables

2011-10-27 Thread Andreas Färber
Am 27.10.2011 13:37, schrieb Peter Maydell: > Add an abstraction layer for defining and using thread-local > variables. For the moment this is implemented only for Linux, > which means they can only be used in restricted circumstances. > The abstraction layer allows us to add POSIX and Win32 suppor

[Qemu-devel] [PATCH v2 1/3] qemu-tls.h: Add abstraction layer for TLS variables

2011-10-27 Thread Peter Maydell
Add an abstraction layer for defining and using thread-local variables. For the moment this is implemented only for Linux, which means they can only be used in restricted circumstances. The abstraction layer allows us to add POSIX and Win32 support later. Signed-off-by: Peter Maydell --- qemu-tl