Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr

2015-06-18 Thread Paolo Bonzini
On 18/06/2015 11:33, Pavel Dovgaluk wrote: > > > /* Temporary aliases until backends are converted. */ > > > #ifdef TARGET_WORDS_BIGENDIAN > > > # define helper_ret_ldsw_mmu helper_be_ldsw_mmu > > > # define helper_ret_lduw_mmu helper_be_lduw_mmu > > > # define helper_ret_ldsl_mmu helper_be_l

Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr

2015-06-18 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 18/06/2015 11:24, Pavel Dovgaluk wrote: > >>> > > +uint16_t helper_call_ldw_cmmu(CPUArchState *env, target_ulong addr, > >>> > > + int mmu_idx, uintptr_t retaddr); > >> > > >> > What about helper_ret_ldw_cmmu for c

Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr

2015-06-18 Thread Paolo Bonzini
On 18/06/2015 11:24, Pavel Dovgaluk wrote: >>> > > +uint16_t helper_call_ldw_cmmu(CPUArchState *env, target_ulong addr, >>> > > + int mmu_idx, uintptr_t retaddr); >> > >> > What about helper_ret_ldw_cmmu for consistency with the DATA_SIZE == 1 >> > case? > tcg.h bre

Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr

2015-06-18 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 17/06/2015 14:42, Pavel Dovgalyuk wrote: > > This patch introduces several helpers to pass return address > > which points to the TB. Correct return address allows correct > > restoring of the guest PC and icount. These functions should be use

Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr

2015-06-18 Thread Aurelien Jarno
On 2015-06-18 10:16, Paolo Bonzini wrote: > > > On 18/06/2015 07:17, Pavel Dovgaluk wrote: > >>> > > > >>> > > static inline RES_TYPE > >>> > > -glue(glue(cpu_ld, USUFFIX), MEMSUFFIX)(CPUArchState *env, > >>> > > target_ulong ptr) > >>> > > +glue(glue(glue(cpu_ld, USUFFIX), MEMSUFFIX), _ra)(CPU

Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr

2015-06-18 Thread Paolo Bonzini
On 18/06/2015 07:17, Pavel Dovgaluk wrote: >>> > > >>> > > static inline RES_TYPE >>> > > -glue(glue(cpu_ld, USUFFIX), MEMSUFFIX)(CPUArchState *env, target_ulong >>> > > ptr) >>> > > +glue(glue(glue(cpu_ld, USUFFIX), MEMSUFFIX), _ra)(CPUArchState *env, >>> > > +

Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr

2015-06-17 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 17/06/2015 14:42, Pavel Dovgalyuk wrote: > > This patch introduces several helpers to pass return address > > which points to the TB. Correct return address allows correct > > restoring of the guest PC and icount. These functions should be use

Re: [Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr

2015-06-17 Thread Paolo Bonzini
On 17/06/2015 14:42, Pavel Dovgalyuk wrote: > This patch introduces several helpers to pass return address > which points to the TB. Correct return address allows correct > restoring of the guest PC and icount. These functions should be used when > helpers embedded into TB invoke memory operation

[Qemu-devel] [PATCH v2 1/3] softmmu: add helper function to pass through retaddr

2015-06-17 Thread Pavel Dovgalyuk
This patch introduces several helpers to pass return address which points to the TB. Correct return address allows correct restoring of the guest PC and icount. These functions should be used when helpers embedded into TB invoke memory operations. Signed-off-by: Pavel Dovgalyuk --- include/exec/