Re: [Qemu-devel] [PATCH v2 1/4] block/ssh: Convert from DPRINTF() macro to trace events

2019-01-14 Thread Philippe Mathieu-Daudé
On 1/14/19 12:15 PM, Max Reitz wrote: > On 13.12.18 17:27, Laurent Vivier wrote: >> Signed-off-by: Laurent Vivier >> Reviewed-by: Richard W.M. Jones >> Reviewed-by: Philippe Mathieu-Daudé >> --- >> >> Notes: >> v2: use %zu with size_t >> change an uint64_t to int64_t to match % PRIi6

Re: [Qemu-devel] [PATCH v2 1/4] block/ssh: Convert from DPRINTF() macro to trace events

2019-01-14 Thread Max Reitz
On 13.12.18 17:27, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > Reviewed-by: Richard W.M. Jones > Reviewed-by: Philippe Mathieu-Daudé > --- > > Notes: > v2: use %zu with size_t > change an uint64_t to int64_t to match % PRIi64 > > block/ssh.c| 46 +++

Re: [Qemu-devel] [PATCH v2 1/4] block/ssh: Convert from DPRINTF() macro to trace events

2018-12-13 Thread Laurent Vivier
On 13/12/2018 17:34, Eric Blake wrote: > On 12/13/18 10:27 AM, Laurent Vivier wrote: >> Signed-off-by: Laurent Vivier >> Reviewed-by: Richard W.M. Jones >> Reviewed-by: Philippe Mathieu-Daudé >> --- >> >> Notes: >> v2: use %zu with size_t >> change an uint64_t to int64_t to match %

Re: [Qemu-devel] [PATCH v2 1/4] block/ssh: Convert from DPRINTF() macro to trace events

2018-12-13 Thread Eric Blake
On 12/13/18 10:27 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier Reviewed-by: Richard W.M. Jones Reviewed-by: Philippe Mathieu-Daudé --- Notes: v2: use %zu with size_t change an uint64_t to int64_t to match % PRIi64 Why PRIi64? It's identical to PRId64, but the sourc

[Qemu-devel] [PATCH v2 1/4] block/ssh: Convert from DPRINTF() macro to trace events

2018-12-13 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard W.M. Jones Reviewed-by: Philippe Mathieu-Daudé --- Notes: v2: use %zu with size_t change an uint64_t to int64_t to match % PRIi64 block/ssh.c| 46 +- block/trace-events | 17