[Qemu-devel] [PATCH v2 1/4] gtk: Use gtk generic event signal instead of motion-notify-event

2014-04-02 Thread Takashi Iwai
The GDK motion-notify-event isn't generated when the pointer goes out of the target window even if the pointer is grabbed, which essentially means to lose the pointer tracking in gtk-ui. Meanwhile the generic event signal is sent when the pointer is grabbed, so we can use this and pick the motion

Re: [Qemu-devel] [PATCH v2 1/4] gtk: Use gtk generic event signal instead of motion-notify-event

2014-04-02 Thread Cole Robinson
On 04/02/2014 08:32 AM, Takashi Iwai wrote: The GDK motion-notify-event isn't generated when the pointer goes out of the target window even if the pointer is grabbed, which essentially means to lose the pointer tracking in gtk-ui. Meanwhile the generic event signal is sent when the pointer

Re: [Qemu-devel] [PATCH v2 1/4] gtk: Use gtk generic event signal instead of motion-notify-event

2014-04-02 Thread Gerd Hoffmann
On Mi, 2014-04-02 at 14:32 +0200, Takashi Iwai wrote: +static gboolean gd_event(GtkWidget *widget, GdkEvent *event, void *opaque) +{ +if (event-type == GDK_MOTION_NOTIFY) +return gd_motion_event(widget, event-motion, opaque); +return FALSE; +} Fails checkpatch: WARNING:

Re: [Qemu-devel] [PATCH v2 1/4] gtk: Use gtk generic event signal instead of motion-notify-event

2014-04-02 Thread Takashi Iwai
At Wed, 02 Apr 2014 17:17:54 +0200, Gerd Hoffmann wrote: On Mi, 2014-04-02 at 14:32 +0200, Takashi Iwai wrote: +static gboolean gd_event(GtkWidget *widget, GdkEvent *event, void *opaque) +{ +if (event-type == GDK_MOTION_NOTIFY) +return gd_motion_event(widget, event-motion,