Re: [Qemu-devel] [PATCH v2 1/4] hw/char: Implement nRF51 SoC UART

2018-08-14 Thread Paolo Bonzini
On 14/08/2018 12:02, Peter Maydell wrote: > On 13 August 2018 at 10:47, Stefan Hajnoczi wrote: >> It's an assumption that on-board devices cannot be hot unplugged and >> that the machine type stays alive until QEMU terminates. >> >> Making this assumption saves 1 call to qemu_chr_fe_set_handlers()

Re: [Qemu-devel] [PATCH v2 1/4] hw/char: Implement nRF51 SoC UART

2018-08-14 Thread Peter Maydell
On 13 August 2018 at 10:47, Stefan Hajnoczi wrote: > It's an assumption that on-board devices cannot be hot unplugged and > that the machine type stays alive until QEMU terminates. > > Making this assumption saves 1 call to qemu_chr_fe_set_handlers(). > The cost is that we cannot safely stop the s

Re: [Qemu-devel] [PATCH v2 1/4] hw/char: Implement nRF51 SoC UART

2018-08-14 Thread Julia Suvorova via Qemu-devel
On 13.08.2018 12:47, Stefan Hajnoczi wrote: On Mon, Aug 13, 2018 at 10:08 AM Julia Suvorova wrote: On 10.08.2018 09:02, Stefan Hajnoczi wrote: On Wed, Aug 8, 2018 at 10:07 PM, Julia Suvorova wrote: +static uint64_t uart_read(void *opaque, hwaddr addr, unsigned int size) +{ +NRF51UARTStat

Re: [Qemu-devel] [PATCH v2 1/4] hw/char: Implement nRF51 SoC UART

2018-08-13 Thread Stefan Hajnoczi
On Mon, Aug 13, 2018 at 10:08 AM Julia Suvorova wrote: > On 10.08.2018 09:02, Stefan Hajnoczi wrote: > > On Wed, Aug 8, 2018 at 10:07 PM, Julia Suvorova wrote: > >> +static uint64_t uart_read(void *opaque, hwaddr addr, unsigned int size) > >> +{ > >> +NRF51UARTState *s = NRF51_UART(opaque); >

Re: [Qemu-devel] [PATCH v2 1/4] hw/char: Implement nRF51 SoC UART

2018-08-13 Thread Julia Suvorova via Qemu-devel
On 10.08.2018 09:02, Stefan Hajnoczi wrote: On Wed, Aug 8, 2018 at 10:07 PM, Julia Suvorova wrote: +static uint64_t uart_read(void *opaque, hwaddr addr, unsigned int size) +{ +NRF51UARTState *s = NRF51_UART(opaque); +uint64_t r; + +if (!s->enabled) { +return 0; +} + +

Re: [Qemu-devel] [PATCH v2 1/4] hw/char: Implement nRF51 SoC UART

2018-08-09 Thread Stefan Hajnoczi
On Wed, Aug 8, 2018 at 10:07 PM, Julia Suvorova wrote: > +static uint64_t uart_read(void *opaque, hwaddr addr, unsigned int size) > +{ > +NRF51UARTState *s = NRF51_UART(opaque); > +uint64_t r; > + > +if (!s->enabled) { > +return 0; > +} > + > +switch (addr) { > +cas

[Qemu-devel] [PATCH v2 1/4] hw/char: Implement nRF51 SoC UART

2018-08-08 Thread Julia Suvorova via Qemu-devel
Not implemented: CTS/NCTS, PSEL*. Signed-off-by: Julia Suvorova --- hw/char/Makefile.objs| 1 + hw/char/nrf51_uart.c | 329 +++ hw/char/trace-events | 4 + include/hw/char/nrf51_uart.h | 78 + 4 files changed, 412 insertions(+)