Re: [Qemu-devel] [PATCH v2 1/4] kbd leds: infrastructure

2010-03-09 Thread Anthony Liguori
On 03/09/2010 10:41 AM, Gerd Hoffmann wrote: On 03/09/10 17:28, Anthony Liguori wrote: If a person has a guest that twiddles with LEDs, what are the chances they are going to figure out that there's an option with VNC to not use LED status as part of the modifier tracking heuristics? I don't th

Re: [Qemu-devel] [PATCH v2 1/4] kbd leds: infrastructure

2010-03-09 Thread Gerd Hoffmann
On 03/09/10 17:28, Anthony Liguori wrote: If a person has a guest that twiddles with LEDs, what are the chances they are going to figure out that there's an option with VNC to not use LED status as part of the modifier tracking heuristics? I don't think it's really useful. Like I said in an earl

Re: [Qemu-devel] [PATCH v2 1/4] kbd leds: infrastructure

2010-03-09 Thread Anthony Liguori
On 03/09/2010 10:13 AM, Gerd Hoffmann wrote: On 03/09/10 16:58, Paul Brook wrote: On 02/26/2010 10:17 AM, Gerd Hoffmann wrote: Adds infrastructure for keyboard led status tracking to qemu. Signed-off-by: Gerd Hoffmann Applied. Thanks. What about guests that use the capslock LED for someth

Re: [Qemu-devel] [PATCH v2 1/4] kbd leds: infrastructure

2010-03-09 Thread Gerd Hoffmann
On 03/09/10 16:58, Paul Brook wrote: On 02/26/2010 10:17 AM, Gerd Hoffmann wrote: Adds infrastructure for keyboard led status tracking to qemu. Signed-off-by: Gerd Hoffmann Applied. Thanks. What about guests that use the capslock LED for something useful, instead of capslock? I offered w

Re: [Qemu-devel] [PATCH v2 1/4] kbd leds: infrastructure

2010-03-09 Thread Anthony Liguori
On 03/09/2010 09:58 AM, Paul Brook wrote: On 02/26/2010 10:17 AM, Gerd Hoffmann wrote: Adds infrastructure for keyboard led status tracking to qemu. Signed-off-by: Gerd Hoffmann Applied. Thanks. What about guests that use the capslock LED for something useful, instead of

Re: [Qemu-devel] [PATCH v2 1/4] kbd leds: infrastructure

2010-03-09 Thread Paul Brook
> On 02/26/2010 10:17 AM, Gerd Hoffmann wrote: > > Adds infrastructure for keyboard led status tracking to qemu. > > > > Signed-off-by: Gerd Hoffmann > > Applied. Thanks. What about guests that use the capslock LED for something useful, instead of capslock? Paul

Re: [Qemu-devel] [PATCH v2 1/4] kbd leds: infrastructure

2010-03-09 Thread Anthony Liguori
On 02/26/2010 10:17 AM, Gerd Hoffmann wrote: Adds infrastructure for keyboard led status tracking to qemu. Signed-off-by: Gerd Hoffmann Applied. Thanks. Regards, Anthony Liguori --- console.h | 15 +++ input.c | 31 +++ 2 files changed,

[Qemu-devel] [PATCH v2 1/4] kbd leds: infrastructure

2010-02-26 Thread Gerd Hoffmann
Adds infrastructure for keyboard led status tracking to qemu. Signed-off-by: Gerd Hoffmann --- console.h | 15 +++ input.c | 31 +++ 2 files changed, 46 insertions(+), 0 deletions(-) diff --git a/console.h b/console.h index 916859d..71e8ff2 100644 -