Re: [Qemu-devel] [PATCH v2 1/4] pci: Split pcie_host_mmcfg_map()

2015-01-27 Thread Paolo Bonzini
On 27/01/2015 15:24, Michael S. Tsirkin wrote: > I suspect this is not the only device that leaks memory now. > Paolo? It should be, this is a bug. Commit d8d95814609e89e5438a3318a647ec322fc4ff16 missed this place due to a rebase error. (I can tell it's a rebase error because I have the fixed

Re: [Qemu-devel] [PATCH v2 1/4] pci: Split pcie_host_mmcfg_map()

2015-01-27 Thread Michael S. Tsirkin
On Tue, Jan 27, 2015 at 01:55:32PM +, Peter Maydell wrote: > On 21 January 2015 at 16:18, Alexander Graf wrote: > > The mmcfg space is a memory region that allows access to PCI config space > > in the PCIe world. To maintain abstraction layers, I would like to expose > > the mmcfg space as a s

Re: [Qemu-devel] [PATCH v2 1/4] pci: Split pcie_host_mmcfg_map()

2015-01-27 Thread Peter Maydell
On 21 January 2015 at 16:18, Alexander Graf wrote: > The mmcfg space is a memory region that allows access to PCI config space > in the PCIe world. To maintain abstraction layers, I would like to expose > the mmcfg space as a sysbus mmio region rather than have it mapped straight > into the system

[Qemu-devel] [PATCH v2 1/4] pci: Split pcie_host_mmcfg_map()

2015-01-21 Thread Alexander Graf
The mmcfg space is a memory region that allows access to PCI config space in the PCIe world. To maintain abstraction layers, I would like to expose the mmcfg space as a sysbus mmio region rather than have it mapped straight into the system's memory address space though. So this patch splits the in