Re: [Qemu-devel] [PATCH v2 1/5] linux-aio: queue requests that cannot be submitted

2014-12-17 Thread Paolo Bonzini
On 17/12/2014 13:34, Paolo Bonzini wrote: > > > On 16/12/2014 21:26, Paolo Bonzini wrote: >> >>> I could reproduce this very well on a random OS image that I had around. >>> This is raw over XFS over dm-crypt, and the image is about 75% sparse >>> (8.2G used over 35G). I only get 1-2%, but st

Re: [Qemu-devel] [PATCH v2 1/5] linux-aio: queue requests that cannot be submitted

2014-12-17 Thread Paolo Bonzini
On 16/12/2014 21:26, Paolo Bonzini wrote: > >> I could reproduce this very well on a random OS image that I had around. >> This is raw over XFS over dm-crypt, and the image is about 75% sparse >> (8.2G used over 35G). I only get 1-2%, but still it's visible. >> >> However I can hardly reproduc

Re: [Qemu-devel] [PATCH v2 1/5] linux-aio: queue requests that cannot be submitted

2014-12-16 Thread Paolo Bonzini
> I could reproduce this very well on a random OS image that I had around. > This is raw over XFS over dm-crypt, and the image is about 75% sparse > (8.2G used over 35G). I only get 1-2%, but still it's visible. > > However I can hardly reproduce it when using a partition directly: > >

Re: [Qemu-devel] [PATCH v2 1/5] linux-aio: queue requests that cannot be submitted

2014-12-16 Thread Paolo Bonzini
On 16/12/2014 14:10, Kevin Wolf wrote: > Am 16.12.2014 um 12:28 hat Paolo Bonzini geschrieben: >> >> >> On 16/12/2014 12:07, Kevin Wolf wrote: >>> Am 11.12.2014 um 14:52 hat Paolo Bonzini geschrieben: Keep a queue of requests that were not submitted; pass them to the kernel when a compl

Re: [Qemu-devel] [PATCH v2 1/5] linux-aio: queue requests that cannot be submitted

2014-12-16 Thread Kevin Wolf
Am 16.12.2014 um 12:28 hat Paolo Bonzini geschrieben: > > > On 16/12/2014 12:07, Kevin Wolf wrote: > > Am 11.12.2014 um 14:52 hat Paolo Bonzini geschrieben: > >> Keep a queue of requests that were not submitted; pass them to > >> the kernel when a completion is reported, unless the queue is > >>

Re: [Qemu-devel] [PATCH v2 1/5] linux-aio: queue requests that cannot be submitted

2014-12-16 Thread Paolo Bonzini
On 16/12/2014 12:07, Kevin Wolf wrote: > Am 11.12.2014 um 14:52 hat Paolo Bonzini geschrieben: >> Keep a queue of requests that were not submitted; pass them to >> the kernel when a completion is reported, unless the queue is >> plugged. >> >> The array of iocbs is rebuilt every time from scratch

Re: [Qemu-devel] [PATCH v2 1/5] linux-aio: queue requests that cannot be submitted

2014-12-16 Thread Kevin Wolf
Am 11.12.2014 um 14:52 hat Paolo Bonzini geschrieben: > Keep a queue of requests that were not submitted; pass them to > the kernel when a completion is reported, unless the queue is > plugged. > > The array of iocbs is rebuilt every time from scratch. This > avoids keeping the iocbs array and li

[Qemu-devel] [PATCH v2 1/5] linux-aio: queue requests that cannot be submitted

2014-12-11 Thread Paolo Bonzini
Keep a queue of requests that were not submitted; pass them to the kernel when a completion is reported, unless the queue is plugged. The array of iocbs is rebuilt every time from scratch. This avoids keeping the iocbs array and list synchronized. Signed-off-by: Paolo Bonzini --- block/linux-a