Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

2017-10-15 Thread Andrew Jeffery
On Wed, 2017-10-11 at 09:28 +0200, Cédric Le Goater wrote: > On 10/11/2017 05:49 AM, Andrew Jeffery wrote: > > On Tue, 2017-10-10 at 15:30 +0200, Cédric Le Goater wrote: > > > On 10/09/2017 02:04 AM, Andrew Jeffery wrote: > > > > On Wed, 2017-09-20 at 09:01 +0200, Cédric Le Goater wrote: > > > > >

Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

2017-10-11 Thread Cédric Le Goater
On 10/11/2017 05:49 AM, Andrew Jeffery wrote: > On Tue, 2017-10-10 at 15:30 +0200, Cédric Le Goater wrote: >> On 10/09/2017 02:04 AM, Andrew Jeffery wrote: >>> On Wed, 2017-09-20 at 09:01 +0200, Cédric Le Goater wrote: The Witherspoon boards are OpenPOWER system hosting POWER9 Processors.

Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

2017-10-10 Thread Andrew Jeffery
On Tue, 2017-10-10 at 15:30 +0200, Cédric Le Goater wrote: > On 10/09/2017 02:04 AM, Andrew Jeffery wrote: > > On Wed, 2017-09-20 at 09:01 +0200, Cédric Le Goater wrote: > > > The Witherspoon boards are OpenPOWER system hosting POWER9 Processors. > > > Let's add support for their BMC including a co

Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

2017-10-10 Thread Cédric Le Goater
On 10/10/2017 05:45 PM, Peter Maydell wrote: > On 10 October 2017 at 16:38, Cédric Le Goater wrote: >> On 10/10/2017 03:24 PM, Peter Maydell wrote: >>> On 10 October 2017 at 14:21, Cédric Le Goater wrote: On 10/10/2017 11:54 AM, Peter Maydell wrote: > The goal is to model hardware correc

Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

2017-10-10 Thread Peter Maydell
On 10 October 2017 at 16:38, Cédric Le Goater wrote: > On 10/10/2017 03:24 PM, Peter Maydell wrote: >> On 10 October 2017 at 14:21, Cédric Le Goater wrote: >>> On 10/10/2017 11:54 AM, Peter Maydell wrote: The goal is to model hardware correctly. Hardware gives aborts if you touch a phys

Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

2017-10-10 Thread Cédric Le Goater
On 10/10/2017 03:24 PM, Peter Maydell wrote: > On 10 October 2017 at 14:21, Cédric Le Goater wrote: >> On 10/10/2017 11:54 AM, Peter Maydell wrote: >>> The goal is to model hardware correctly. Hardware gives >>> aborts if you touch a physical address with no device there, >>> and so QEMU's model s

Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

2017-10-10 Thread Peter Maydell
On 10 October 2017 at 14:30, Cédric Le Goater wrote: > On 10/09/2017 02:04 AM, Andrew Jeffery wrote: >> On Wed, 2017-09-20 at 09:01 +0200, Cédric Le Goater wrote: >>> +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc) >>> +{ >>> +AspeedSoCState *soc = &bmc->soc; >>> + >>> +i2c_cr

Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

2017-10-10 Thread Cédric Le Goater
On 10/09/2017 02:04 AM, Andrew Jeffery wrote: > On Wed, 2017-09-20 at 09:01 +0200, Cédric Le Goater wrote: >> The Witherspoon boards are OpenPOWER system hosting POWER9 Processors. >> Let's add support for their BMC including a couple of I2C devices as >> found on real HW. >>   >> Signed-off-by: Cé

Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

2017-10-10 Thread Peter Maydell
On 10 October 2017 at 14:21, Cédric Le Goater wrote: > On 10/10/2017 11:54 AM, Peter Maydell wrote: >> The goal is to model hardware correctly. Hardware gives >> aborts if you touch a physical address with no device there, >> and so QEMU's model should do the same. If you have guest >> code that t

Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

2017-10-10 Thread Cédric Le Goater
On 10/10/2017 11:54 AM, Peter Maydell wrote: > On 10 October 2017 at 10:19, Cédric Le Goater wrote: >> On 10/06/2017 05:10 PM, Peter Maydell wrote: +mc->ignore_memory_transaction_failures = true; >>> >>> Please don't set this flag for new board models, it is only >>> for our legacy existi

Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

2017-10-10 Thread Peter Maydell
On 10 October 2017 at 10:19, Cédric Le Goater wrote: > On 10/06/2017 05:10 PM, Peter Maydell wrote: >>> +mc->ignore_memory_transaction_failures = true; >> >> Please don't set this flag for new board models, it is only >> for our legacy existing ones. Instead implement any devices >> that you n

Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

2017-10-10 Thread Cédric Le Goater
On 10/06/2017 05:10 PM, Peter Maydell wrote: > On 20 September 2017 at 08:01, Cédric Le Goater wrote: >> The Witherspoon boards are OpenPOWER system hosting POWER9 Processors. >> Let's add support for their BMC including a couple of I2C devices as >> found on real HW. >> >> Signed-off-by: Cédric L

Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

2017-10-08 Thread Andrew Jeffery
On Wed, 2017-09-20 at 09:01 +0200, Cédric Le Goater wrote: > The Witherspoon boards are OpenPOWER system hosting POWER9 Processors. > Let's add support for their BMC including a couple of I2C devices as > found on real HW. >  > Signed-off-by: Cédric Le Goater > --- >  hw/arm/aspeed.c | 49

Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

2017-10-07 Thread Cédric Le Goater
On 10/06/2017 05:10 PM, Peter Maydell wrote: > On 20 September 2017 at 08:01, Cédric Le Goater wrote: >> The Witherspoon boards are OpenPOWER system hosting POWER9 Processors. >> Let's add support for their BMC including a couple of I2C devices as >> found on real HW. >> >> Signed-off-by: Cédric L

Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

2017-10-06 Thread Peter Maydell
On 20 September 2017 at 08:01, Cédric Le Goater wrote: > The Witherspoon boards are OpenPOWER system hosting POWER9 Processors. > Let's add support for their BMC including a couple of I2C devices as > found on real HW. > > Signed-off-by: Cédric Le Goater > --- > hw/arm/aspeed.c | 49

[Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

2017-09-20 Thread Cédric Le Goater
The Witherspoon boards are OpenPOWER system hosting POWER9 Processors. Let's add support for their BMC including a couple of I2C devices as found on real HW. Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 49 + 1 file changed, 49 insertions(