Re: [Qemu-devel] [PATCH v2 1/6] nbd/server: add additional assert to nbd_export_put

2018-01-10 Thread Eric Blake
On 12/07/2017 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: > This place is not obvious, nbd_export_close may theoretically reduce > refcount to 0. It may happen if someone calls nbd_export_put on named > export not through nbd_export_set_name when refcount is 1. > > Signed-off-by: Vladimir Sement

[Qemu-devel] [PATCH v2 1/6] nbd/server: add additional assert to nbd_export_put

2017-12-07 Thread Vladimir Sementsov-Ogievskiy
This place is not obvious, nbd_export_close may theoretically reduce refcount to 0. It may happen if someone calls nbd_export_put on named export not through nbd_export_set_name when refcount is 1. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Max Reitz --- n