Re: [Qemu-devel] [PATCH v2 1/6] target/arm64: properly handle DBGVR RESS bits

2018-11-08 Thread Alex Bennée
Richard Henderson writes: > On 11/8/18 5:33 PM, Alex Bennée wrote: >> -.bvr = addr >> +.bvr = sextract64(addr, 52, 53) > > I think you meant sextract64(addr, 0, 53). > What you wrote *should* have asserted, since 52+53 > 64. Dam, I did fix that. I must have failed to propagate

Re: [Qemu-devel] [PATCH v2 1/6] target/arm64: properly handle DBGVR RESS bits

2018-11-08 Thread Richard Henderson
On 11/8/18 5:33 PM, Alex Bennée wrote: > -.bvr = addr > +.bvr = sextract64(addr, 52, 53) I think you meant sextract64(addr, 0, 53). What you wrote *should* have asserted, since 52+53 > 64. r~

[Qemu-devel] [PATCH v2 1/6] target/arm64: properly handle DBGVR RESS bits

2018-11-08 Thread Alex Bennée
This only fails with some (broken) versions of gdb but we should treat the top bits of DBGBVR as RESS. Properly sign extend QEMU's reference copy of dbgbvr and also update the register descriptions in the comment. Signed-off-by: Alex Bennée --- v2 - sanitise register on insertion - update re