On 05/09/2017 08:17 AM, Aurelien Jarno wrote:
Ok, thanks for the detailed explanations. Then I guess you should fold
the following patch to correctly set the zArch active bit as done in
s390_fill_feat_block:
--- a/target/s390x/misc_helper.c
+++ b/target/s390x/misc_helper.c
@@ -693,6 +693,11 @@
On 2017-05-09 07:51, Richard Henderson wrote:
> On 05/09/2017 01:14 AM, Aurelien Jarno wrote:
> > > +/* The maximum bit defined at the moment is 129. */
> > > +#define MAX_STFL_WORDS 3
> >
> > Could it be computed from S390_FEAT_MAX? in gen-features.c,
> > S390_FEAT_MAX / 64 + 1 is used.
>
>
On 05/09/2017 07:51 AM, Richard Henderson wrote:
I'm pleased to see this appears to have been dropped at some point; I cannot
see it present in linux 4.11. However, this still applies to the kernels
supplied by the shipping distributions.
More accurately, it has been moved to
On 05/09/2017 01:14 AM, Aurelien Jarno wrote:
+/* The maximum bit defined at the moment is 129. */
+#define MAX_STFL_WORDS 3
Could it be computed from S390_FEAT_MAX? in gen-features.c,
S390_FEAT_MAX / 64 + 1 is used.
No, because the features list in cpu_features_def.h bears no relation to
On 2017-05-08 08:17, Richard Henderson wrote:
> At the same time, improve STORE FACILITIES LIST
> so that we don't hard-code the list for all cpus.
>
> Signed-off-by: Richard Henderson
> ---
> target/s390x/helper.h | 2 ++
> target/s390x/insn-data.def | 2 ++
>
At the same time, improve STORE FACILITIES LIST
so that we don't hard-code the list for all cpus.
Signed-off-by: Richard Henderson
---
target/s390x/helper.h | 2 ++
target/s390x/insn-data.def | 2 ++
target/s390x/misc_helper.c | 54