Re: [Qemu-devel] [PATCH v2 1/9] ccid-card-passthru: Move assertion in read() to can_read()

Hi On Thu, Feb 14, 2019 at 9:19 PM Philippe Mathieu-Daudé wrote: > > chardev::read() depends of what chardev::can_read() returns, move the > assertion to can_read(). > > Suggested-by: Paolo Bonzini > Signed-off-by: Philippe Mathieu-Daudé Moving to can_read() makes sense, because nothing

Re: [Qemu-devel] [PATCH v2 1/9] ccid-card-passthru: Move assertion in read() to can_read()

On Thu, Feb 14, 2019 at 09:19:31PM +0100, Philippe Mathieu-Daudé wrote: >chardev::read() depends of what chardev::can_read() returns, move the >assertion to can_read(). > >Suggested-by: Paolo Bonzini >Signed-off-by: Philippe Mathieu-Daudé >--- > hw/usb/ccid-card-passthru.c | 5 ++--- > 1 file

Re: [Qemu-devel] [PATCH v2 1/9] ccid-card-passthru: Move assertion in read() to can_read()

On 2/14/19 2:19 PM, Philippe Mathieu-Daudé wrote: > chardev::read() depends of what chardev::can_read() returns, move the s/of/on/ > assertion to can_read(). > > Suggested-by: Paolo Bonzini > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/usb/ccid-card-passthru.c | 5 ++--- > 1 file

[Qemu-devel] [PATCH v2 1/9] ccid-card-passthru: Move assertion in read() to can_read()

chardev::read() depends of what chardev::can_read() returns, move the assertion to can_read(). Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/ccid-card-passthru.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/usb/ccid-card-passthru.c