Re: [Qemu-devel] [PATCH v2 1/9] jobs: change start callback to run callback

2018-08-31 Thread Max Reitz
On 2018-08-30 02:06, John Snow wrote: > > > On 08/27/2018 05:30 AM, Max Reitz wrote: >> On 2018-08-24 00:08, John Snow wrote: >>> Presently we codify the entry point for a job as the "start" callback, >>> but a more apt name would be "run" to clarify the idea that when this >>> function returns

Re: [Qemu-devel] [PATCH v2 1/9] jobs: change start callback to run callback

2018-08-29 Thread John Snow
On 08/27/2018 05:30 AM, Max Reitz wrote: > On 2018-08-24 00:08, John Snow wrote: >> Presently we codify the entry point for a job as the "start" callback, >> but a more apt name would be "run" to clarify the idea that when this >> function returns we consider the job to have "finished," except

Re: [Qemu-devel] [PATCH v2 1/9] jobs: change start callback to run callback

2018-08-27 Thread Max Reitz
On 2018-08-24 00:08, John Snow wrote: > Presently we codify the entry point for a job as the "start" callback, > but a more apt name would be "run" to clarify the idea that when this > function returns we consider the job to have "finished," except for > any cleanup which occurs in separate

[Qemu-devel] [PATCH v2 1/9] jobs: change start callback to run callback

2018-08-23 Thread John Snow
Presently we codify the entry point for a job as the "start" callback, but a more apt name would be "run" to clarify the idea that when this function returns we consider the job to have "finished," except for any cleanup which occurs in separate callbacks later. As part of this clarification,