Re: [Qemu-devel] [PATCH v2 1/9] nbd: Allow unmap and fua during write zeroes

2016-11-18 Thread Paolo Bonzini
On 17/11/2016 22:10, Max Reitz wrote: > On 17.11.2016 21:13, Eric Blake wrote: >> Commit fa778fff wired up support to send the NBD_CMD_WRITE_ZEROES, >> but forgot to inform the block layer that FUA unmapping of zeroes is >> supported. Without BDRV_REQ_MAY_UNMAP listed as a supported flag, >>

Re: [Qemu-devel] [PATCH v2 1/9] nbd: Allow unmap and fua during write zeroes

2016-11-17 Thread Eric Blake
On 11/17/2016 03:10 PM, Max Reitz wrote: > On 17.11.2016 21:13, Eric Blake wrote: >> Commit fa778fff wired up support to send the NBD_CMD_WRITE_ZEROES, >> but forgot to inform the block layer that FUA unmapping of zeroes is >> supported. Without BDRV_REQ_MAY_UNMAP listed as a supported flag, >>

Re: [Qemu-devel] [PATCH v2 1/9] nbd: Allow unmap and fua during write zeroes

2016-11-17 Thread Max Reitz
On 17.11.2016 21:13, Eric Blake wrote: > Commit fa778fff wired up support to send the NBD_CMD_WRITE_ZEROES, > but forgot to inform the block layer that FUA unmapping of zeroes is > supported. Without BDRV_REQ_MAY_UNMAP listed as a supported flag, > the block layer will always insist on the NBD

[Qemu-devel] [PATCH v2 1/9] nbd: Allow unmap and fua during write zeroes

2016-11-17 Thread Eric Blake
Commit fa778fff wired up support to send the NBD_CMD_WRITE_ZEROES, but forgot to inform the block layer that FUA unmapping of zeroes is supported. Without BDRV_REQ_MAY_UNMAP listed as a supported flag, the block layer will always insist on the NBD layer passing NBD_CMD_FLAG_NO_HOLE, resulting in