Re: [Qemu-devel] [PATCH v2 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-15 Thread Markus Armbruster
Fam Zheng writes: > On Sat, 09/13 17:00, Markus Armbruster wrote: >> The patch is big, but all it really does is replacing >> >> dinfo->bdrv >> >> by >> >> blk_bs(blk_legacy_dinfo(dinfo)) > > s/blk_legacy_dinfo/blk_by_legacy_dinfo/ > > Otherwise looks good, > > Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH v2 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-15 Thread Fam Zheng
On Sat, 09/13 17:00, Markus Armbruster wrote: > The patch is big, but all it really does is replacing > > dinfo->bdrv > > by > > blk_bs(blk_legacy_dinfo(dinfo)) s/blk_legacy_dinfo/blk_by_legacy_dinfo/ Otherwise looks good, Reviewed-by: Fam Zheng > > The replacement is repetitive, b

[Qemu-devel] [PATCH v2 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-13 Thread Markus Armbruster
The patch is big, but all it really does is replacing dinfo->bdrv by blk_bs(blk_legacy_dinfo(dinfo)) The replacement is repetitive, but the conversion of device models to BlockBackend is imminent, and will shorten it to just blk_legacy_dinfo(dinfo). Line wrapping muddies the waters a b