Re: [Qemu-devel] [PATCH v2 11/12] cpus: call cpu_update_icount on read

2017-04-07 Thread Richard Henderson
On 04/07/2017 06:14 AM, Alex Bennée wrote: Sorry, I meant we should generate TCG opcodes for the translation in gen_io_start. Ahh OK. I think this is 2.10 stuff though right? Definitely. r~

Re: [Qemu-devel] [PATCH v2 11/12] cpus: call cpu_update_icount on read

2017-04-07 Thread Alex Bennée
Paolo Bonzini writes: > - Original Message - >> From: "Alex Bennée" >> To: "Paolo Bonzini" >> Cc: dovga...@ispras.ru, r...@twiddle.net, "peter maydell" >> , qemu-devel@nongnu.org, >> mt...@greensocs.com, "fred konrad" , "a rigo" >> , >> c...@braap.org, "bobby prani" , >> nik...@linu

Re: [Qemu-devel] [PATCH v2 11/12] cpus: call cpu_update_icount on read

2017-04-07 Thread Paolo Bonzini
- Original Message - > From: "Alex Bennée" > To: "Paolo Bonzini" > Cc: dovga...@ispras.ru, r...@twiddle.net, "peter maydell" > , qemu-devel@nongnu.org, > mt...@greensocs.com, "fred konrad" , "a rigo" > , > c...@braap.org, "bobby prani" , > nik...@linux.vnet.ibm.com, "Peter Crosthwait

Re: [Qemu-devel] [PATCH v2 11/12] cpus: call cpu_update_icount on read

2017-04-07 Thread Alex Bennée
Paolo Bonzini writes: > On 05/04/2017 15:25, Alex Bennée wrote: >> This ensures each time the vCPU thread reads the icount we update the >> master timer_state.qemu_icount field. This way as long as updates are >> in BQL protected sections (which they should be) the main-loop can >> never come to

Re: [Qemu-devel] [PATCH v2 11/12] cpus: call cpu_update_icount on read

2017-04-05 Thread Paolo Bonzini
On 05/04/2017 15:25, Alex Bennée wrote: > This ensures each time the vCPU thread reads the icount we update the > master timer_state.qemu_icount field. This way as long as updates are > in BQL protected sections (which they should be) the main-loop can > never come to update the log and find time

[Qemu-devel] [PATCH v2 11/12] cpus: call cpu_update_icount on read

2017-04-05 Thread Alex Bennée
This ensures each time the vCPU thread reads the icount we update the master timer_state.qemu_icount field. This way as long as updates are in BQL protected sections (which they should be) the main-loop can never come to update the log and find time has gone backwards. Signed-off-by: Alex Bennée