Re: [Qemu-devel] [PATCH v2 11/35] target-arm: Split cpreg access checks out from read/write functions

2014-02-10 Thread Peter Crosthwaite
On Sun, Feb 9, 2014 at 10:02 PM, Peter Maydell wrote: > On 9 February 2014 02:50, Peter Crosthwaite > wrote: >> On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell >> wrote: >>> +typedef enum CPAccessResult { >>> +/* Access is permitted */ >>> +CP_ACCESS_OK = 0, >>> +/* Access fails due t

Re: [Qemu-devel] [PATCH v2 11/35] target-arm: Split cpreg access checks out from read/write functions

2014-02-10 Thread Peter Crosthwaite
On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell wrote: > Several of the system registers handled via the ARMCPRegInfo > mechanism have access trap control bits controlling whether the > registers are accessible to lower privilege levels. Replace > the existing mechanism (allowing the read and write

Re: [Qemu-devel] [PATCH v2 11/35] target-arm: Split cpreg access checks out from read/write functions

2014-02-09 Thread Peter Maydell
On 9 February 2014 02:50, Peter Crosthwaite wrote: > On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell > wrote: >> +typedef enum CPAccessResult { >> +/* Access is permitted */ >> +CP_ACCESS_OK = 0, >> +/* Access fails due to a configurable trap or enable which would >> + * result in

Re: [Qemu-devel] [PATCH v2 11/35] target-arm: Split cpreg access checks out from read/write functions

2014-02-08 Thread Peter Crosthwaite
On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell wrote: > Several of the system registers handled via the ARMCPRegInfo > mechanism have access trap control bits controlling whether the > registers are accessible to lower privilege levels. Replace > the existing mechanism (allowing the read and write

[Qemu-devel] [PATCH v2 11/35] target-arm: Split cpreg access checks out from read/write functions

2014-01-31 Thread Peter Maydell
Several of the system registers handled via the ARMCPRegInfo mechanism have access trap control bits controlling whether the registers are accessible to lower privilege levels. Replace the existing mechanism (allowing the read and write functions to return EXCP_UDEF if access is denied) with a dedi