Re: [Qemu-devel] [PATCH v2 12/13] virtio-gpu: Wrap in vmstate

2016-07-15 Thread Gerd Hoffmann
Hi, > Hmm yes; I think the right fix here is to convert that into > migrate_add_blocker / migrate_del_blocker Oh, didn't notice we have that, yes that sounds good. cheers, Gerd

Re: [Qemu-devel] [PATCH v2 12/13] virtio-gpu: Wrap in vmstate

2016-07-14 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > On Di, 2016-07-12 at 16:02 +0200, Cornelia Huck wrote: > > On Tue, 12 Jul 2016 15:54:57 +0200 > > Gerd Hoffmann wrote: > > > > > > @@ -1170,9 +1166,6 @@ static void virtio_gpu_device_realize(DeviceState > > > > *qdev, Error **errp) > > > > > > > >

Re: [Qemu-devel] [PATCH v2 12/13] virtio-gpu: Wrap in vmstate

2016-07-12 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > On Di, 2016-07-12 at 16:02 +0200, Cornelia Huck wrote: > > On Tue, 12 Jul 2016 15:54:57 +0200 > > Gerd Hoffmann wrote: > > > > > > @@ -1170,9 +1166,6 @@ static void virtio_gpu_device_realize(DeviceState > > > > *qdev, Error **errp) > > > > > > > >

Re: [Qemu-devel] [PATCH v2 12/13] virtio-gpu: Wrap in vmstate

2016-07-12 Thread Gerd Hoffmann
On Di, 2016-07-12 at 16:02 +0200, Cornelia Huck wrote: > On Tue, 12 Jul 2016 15:54:57 +0200 > Gerd Hoffmann wrote: > > > > @@ -1170,9 +1166,6 @@ static void virtio_gpu_device_realize(DeviceState > > > *qdev, Error **errp) > > > > > > if (virtio_gpu_virgl_enabled(g->conf)) { > > >

Re: [Qemu-devel] [PATCH v2 12/13] virtio-gpu: Wrap in vmstate

2016-07-12 Thread Cornelia Huck
On Tue, 12 Jul 2016 15:54:57 +0200 Gerd Hoffmann wrote: > > @@ -1170,9 +1166,6 @@ static void virtio_gpu_device_realize(DeviceState > > *qdev, Error **errp) > > > > if (virtio_gpu_virgl_enabled(g->conf)) { > > vmstate_register(qdev, -1, &vmstate_virtio_gpu_unmigratable, g); > > -

Re: [Qemu-devel] [PATCH v2 12/13] virtio-gpu: Wrap in vmstate

2016-07-12 Thread Gerd Hoffmann
> @@ -1170,9 +1166,6 @@ static void virtio_gpu_device_realize(DeviceState > *qdev, Error **errp) > > if (virtio_gpu_virgl_enabled(g->conf)) { > vmstate_register(qdev, -1, &vmstate_virtio_gpu_unmigratable, g); > -} else { > -register_savevm(qdev, "virtio-gpu", -1, VIRTIO

[Qemu-devel] [PATCH v2 12/13] virtio-gpu: Wrap in vmstate

2016-07-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Forcibly convert it to a vmstate wrapper; proper conversion comes later. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Cornelia Huck --- hw/display/virtio-gpu.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/hw/displ