Re: [Qemu-devel] [PATCH v2 12/14] qemu-img: Make MapEntry a QAPI struct

2015-11-25 Thread Eric Blake
On 11/25/2015 12:39 AM, Fam Zheng wrote: > The "flags" bit mask is expanded to two booleans, "data" and "zero"; > "bs" is replaced with "filename" string. > > Signed-off-by: Fam Zheng > --- > qapi/block-core.json | 28 > qemu-img.c | 48

Re: [Qemu-devel] [PATCH v2 12/14] qemu-img: Make MapEntry a QAPI struct

2015-11-25 Thread Paolo Bonzini
On 25/11/2015 08:39, Fam Zheng wrote: > */ > -if (next && > -(next->flags & (BDRV_BLOCK_DATA|BDRV_BLOCK_ZERO)) != > BDRV_BLOCK_DATA) { > -next->flags &= ~BDRV_BLOCK_DATA; > -next->flags |= BDRV_BLOCK_ZERO; > +if (next && !next->data)

Re: [Qemu-devel] [PATCH v2 12/14] qemu-img: Make MapEntry a QAPI struct

2015-11-25 Thread Fam Zheng
On Wed, 11/25 08:36, Eric Blake wrote: > On 11/25/2015 12:39 AM, Fam Zheng wrote: > > The "flags" bit mask is expanded to two booleans, "data" and "zero"; > > "bs" is replaced with "filename" string. > > > > Signed-off-by: Fam Zheng > > --- > > qapi/block-core.json | 28

[Qemu-devel] [PATCH v2 12/14] qemu-img: Make MapEntry a QAPI struct

2015-11-24 Thread Fam Zheng
The "flags" bit mask is expanded to two booleans, "data" and "zero"; "bs" is replaced with "filename" string. Signed-off-by: Fam Zheng --- qapi/block-core.json | 28 qemu-img.c | 48 ++-- 2 files