Re: [Qemu-devel] [PATCH v2 13/19] qapi-visit: Simplify visit of empty branch in union

2016-03-03 Thread Markus Armbruster
Eric Blake writes: > Now that we have is_empty() and gen_visit_fields_call(), it's s/fields/members/. Better grep all the commit messages for "fields". > fairly easy to skip the visit of a variant type that has no > members. I figure that alone would've been just as easy before gen_visit_memb

[Qemu-devel] [PATCH v2 13/19] qapi-visit: Simplify visit of empty branch in union

2016-02-25 Thread Eric Blake
Now that we have is_empty() and gen_visit_fields_call(), it's fairly easy to skip the visit of a variant type that has no members. Only one such instance exists at the moment (CpuInfoOther), but the idea of a union where some branches add no fields beyond the base type is common enough that we may