Re: [Qemu-devel] [PATCH v2 15/19] qapi-visit: Move error check into gen_visit_members_call()

2016-03-04 Thread Eric Blake
On 03/03/2016 04:56 AM, Markus Armbruster wrote: > Eric Blake writes: > >> When first introduced, neither branch of gen_visit_members_call() >> would output a goto. But now that the implicit struct visit >> always ends with a goto, we should do the same for regular >> struct visits, so that call

Re: [Qemu-devel] [PATCH v2 15/19] qapi-visit: Move error check into gen_visit_members_call()

2016-03-03 Thread Markus Armbruster
Eric Blake writes: > When first introduced, neither branch of gen_visit_members_call() > would output a goto. But now that the implicit struct visit > always ends with a goto, we should do the same for regular > struct visits, so that callers don't have to worry about whether > they are creating

[Qemu-devel] [PATCH v2 15/19] qapi-visit: Move error check into gen_visit_members_call()

2016-02-25 Thread Eric Blake
When first introduced, neither branch of gen_visit_members_call() would output a goto. But now that the implicit struct visit always ends with a goto, we should do the same for regular struct visits, so that callers don't have to worry about whether they are creating two identical goto's in a row.