Re: [Qemu-devel] [PATCH v2 16/19] qapi: Allow anonymous base for flat union

2016-03-04 Thread Eric Blake
On 03/03/2016 06:04 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Rather than requiring all flat unions to explicitly create >> a separate base struct, we can allow the qapi schema to specify >> the common members via an inline dictionary. This is similar to >> how commands can specify a

Re: [Qemu-devel] [PATCH v2 16/19] qapi: Allow anonymous base for flat union

2016-03-03 Thread Markus Armbruster
Eric Blake writes: > Rather than requiring all flat unions to explicitly create > a separate base struct, we can allow the qapi schema to specify > the common members via an inline dictionary. This is similar to > how commands can specify an inline anonymous type for its 'data', Suggest to end t

[Qemu-devel] [PATCH v2 16/19] qapi: Allow anonymous base for flat union

2016-02-25 Thread Eric Blake
Rather than requiring all flat unions to explicitly create a separate base struct, we can allow the qapi schema to specify the common members via an inline dictionary. This is similar to how commands can specify an inline anonymous type for its 'data', and matches the fact that our code base alread