Re: [Qemu-devel] [PATCH v2 17/40] job: Move BlockJobCreateFlags to Job

2018-05-24 Thread John Snow
On 05/24/2018 04:17 AM, Kevin Wolf wrote: > Am 24.05.2018 um 00:24 hat John Snow geschrieben: >> >> >> On 05/18/2018 09:20 AM, Kevin Wolf wrote: >>> +job->auto_finalize = !(flags & JOB_MANUAL_FINALIZE); >>> +job->auto_dismiss = !(flags & JOB_MANUAL_DISMISS); >> >> Job API might be a good

Re: [Qemu-devel] [PATCH v2 17/40] job: Move BlockJobCreateFlags to Job

2018-05-24 Thread Kevin Wolf
Am 24.05.2018 um 00:24 hat John Snow geschrieben: > > > On 05/18/2018 09:20 AM, Kevin Wolf wrote: > > +job->auto_finalize = !(flags & JOB_MANUAL_FINALIZE); > > +job->auto_dismiss = !(flags & JOB_MANUAL_DISMISS); > > Job API might be a good chance to say "No, this is the default behavior

Re: [Qemu-devel] [PATCH v2 17/40] job: Move BlockJobCreateFlags to Job

2018-05-23 Thread John Snow
On 05/18/2018 09:20 AM, Kevin Wolf wrote: > +job->auto_finalize = !(flags & JOB_MANUAL_FINALIZE); > +job->auto_dismiss = !(flags & JOB_MANUAL_DISMISS); Job API might be a good chance to say "No, this is the default behavior for this API." I don't know how possible this is, but could we

[Qemu-devel] [PATCH v2 17/40] job: Move BlockJobCreateFlags to Job

2018-05-18 Thread Kevin Wolf
This renames the BlockJobCreateFlags constants, moves a few JOB_INTERNAL checks to job_create() and the auto_{finalize,dismiss} fields from BlockJob to Job. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- include/block/blockjob.h | 17 - include/block/blockjob_int.h |