Re: [Qemu-devel] [PATCH v2 2/2] PCI-e device multi-function hot-add support

2015-09-23 Thread Alex Williamson
On Wed, 2015-09-23 at 21:37 +0800, Cao jin wrote: > Hi Alex, > > On 09/23/2015 01:51 AM, Alex Williamson wrote: > > On Tue, 2015-09-22 at 18:08 +0800, Cao jin wrote: > >> Hi Alex > >> > >> On 09/22/2015 02:00 AM, Alex Williamson wrote: > >>> > >>> Please use different subjects that uniquely identi

Re: [Qemu-devel] [PATCH v2 2/2] PCI-e device multi-function hot-add support

2015-09-23 Thread Cao jin
Hi Alex, On 09/23/2015 01:51 AM, Alex Williamson wrote: On Tue, 2015-09-22 at 18:08 +0800, Cao jin wrote: Hi Alex On 09/22/2015 02:00 AM, Alex Williamson wrote: Please use different subjects that uniquely identify what each patch does, don't simply re-use the subject for the cover patch on e

Re: [Qemu-devel] [PATCH v2 2/2] PCI-e device multi-function hot-add support

2015-09-22 Thread Alex Williamson
On Tue, 2015-09-22 at 18:08 +0800, Cao jin wrote: > Hi Alex > > On 09/22/2015 02:00 AM, Alex Williamson wrote: > > > > Please use different subjects that uniquely identify what each patch > > does, don't simply re-use the subject for the cover patch on each. > > OK, will change it in next version

Re: [Qemu-devel] [PATCH v2 2/2] PCI-e device multi-function hot-add support

2015-09-22 Thread Cao jin
Hi Alex On 09/22/2015 02:00 AM, Alex Williamson wrote: Please use different subjects that uniquely identify what each patch does, don't simply re-use the subject for the cover patch on each. OK, will change it in next version. On Wed, 2015-09-16 at 10:02 +0800, Cao jin wrote: In case user

Re: [Qemu-devel] [PATCH v2 2/2] PCI-e device multi-function hot-add support

2015-09-21 Thread Alex Williamson
Please use different subjects that uniquely identify what each patch does, don't simply re-use the subject for the cover patch on each. On Wed, 2015-09-16 at 10:02 +0800, Cao jin wrote: > In case user regret when hot-add multi-function, we should roll back, > device_del the function added but st

[Qemu-devel] [PATCH v2 2/2] PCI-e device multi-function hot-add support

2015-09-15 Thread Cao jin
In case user regret when hot-add multi-function, we should roll back, device_del the function added but still not worked. Signed-off-by: Cao jin --- hw/pci/pcie.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 89bf61b..497f390 100644 -