Re: [Qemu-devel] [PATCH v2 2/2] block/io: use qemu_iovec_init_buf

2019-02-06 Thread Eric Blake
On 2/6/19 12:26 PM, Vladimir Sementsov-Ogievskiy wrote: >>> shows a lot of, exactly 34 after io.c already updated. >>> They are in different subsystems, so I think it should be simpler to push >>> this >>> one as a precedent and example, and then send separate patches (or series) >>>

Re: [Qemu-devel] [PATCH v2 2/2] block/io: use qemu_iovec_init_buf

2019-02-06 Thread Vladimir Sementsov-Ogievskiy
06.02.2019 21:14, Eric Blake wrote: > On 2/6/19 12:09 PM, Vladimir Sementsov-Ogievskiy wrote: >> 06.02.2019 20:32, Eric Blake wrote: >>> On 2/6/19 10:53 AM, Vladimir Sementsov-Ogievskiy wrote: Use new qemu_iovec_init_buf() instead of qemu_iovec_init_external( ... , 1), which simplifies

Re: [Qemu-devel] [PATCH v2 2/2] block/io: use qemu_iovec_init_buf

2019-02-06 Thread Eric Blake
On 2/6/19 12:09 PM, Vladimir Sementsov-Ogievskiy wrote: > 06.02.2019 20:32, Eric Blake wrote: >> On 2/6/19 10:53 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Use new qemu_iovec_init_buf() instead of >>> qemu_iovec_init_external( ... , 1), which simplifies the code. >> >> Did you just do a manual

Re: [Qemu-devel] [PATCH v2 2/2] block/io: use qemu_iovec_init_buf

2019-02-06 Thread Vladimir Sementsov-Ogievskiy
06.02.2019 20:32, Eric Blake wrote: > On 2/6/19 10:53 AM, Vladimir Sementsov-Ogievskiy wrote: >> Use new qemu_iovec_init_buf() instead of >> qemu_iovec_init_external( ... , 1), which simplifies the code. > > Did you just do a manual search for candidate callers? > > As you said in the cover

Re: [Qemu-devel] [PATCH v2 2/2] block/io: use qemu_iovec_init_buf

2019-02-06 Thread Eric Blake
On 2/6/19 10:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Use new qemu_iovec_init_buf() instead of > qemu_iovec_init_external( ... , 1), which simplifies the code. Did you just do a manual search for candidate callers? As you said in the cover letter, there are other files that can benefit as

[Qemu-devel] [PATCH v2 2/2] block/io: use qemu_iovec_init_buf

2019-02-06 Thread Vladimir Sementsov-Ogievskiy
Use new qemu_iovec_init_buf() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 90 +- 1 file changed, 21 insertions(+), 69 deletions(-) diff --git