On 17.6.2013 17:16, Kevin Wolf wrote:
Am 17.06.2013 um 16:59 hat Luiz Capitulino geschrieben:
On Mon, 17 Jun 2013 16:49:11 +0200
Kevin Wolf wrote:
Am 17.06.2013 um 15:51 hat Luiz Capitulino geschrieben:
On Mon, 17 Jun 2013 15:46:52 +0200
Kevin Wolf wrote:
Am 17.06.2013 um 15:38 hat Pavel
On Mon, 17 Jun 2013 16:49:11 +0200
Kevin Wolf wrote:
> Am 17.06.2013 um 15:51 hat Luiz Capitulino geschrieben:
> > On Mon, 17 Jun 2013 15:46:52 +0200
> > Kevin Wolf wrote:
> >
> > > Am 17.06.2013 um 15:38 hat Pavel Hrdina geschrieben:
> > > > >It's just a warning, that you used a password f
Am 17.06.2013 um 16:59 hat Luiz Capitulino geschrieben:
> On Mon, 17 Jun 2013 16:49:11 +0200
> Kevin Wolf wrote:
>
> > Am 17.06.2013 um 15:51 hat Luiz Capitulino geschrieben:
> > > On Mon, 17 Jun 2013 15:46:52 +0200
> > > Kevin Wolf wrote:
> > >
> > > > Am 17.06.2013 um 15:38 hat Pavel Hrdina g
Am 17.06.2013 um 15:51 hat Luiz Capitulino geschrieben:
> On Mon, 17 Jun 2013 15:46:52 +0200
> Kevin Wolf wrote:
>
> > Am 17.06.2013 um 15:38 hat Pavel Hrdina geschrieben:
> > > >It's just a warning, that you used a password for a block device that
> > > >doesn't require it. The device is
On Mon, 17 Jun 2013 15:46:52 +0200
Kevin Wolf wrote:
> Am 17.06.2013 um 15:38 hat Pavel Hrdina geschrieben:
> > >It's just a warning, that you used a password for a block device that
> > >doesn't require it. The device is opened successfully and should be
> > >handled correctly (call
Am 17.06.2013 um 15:38 hat Pavel Hrdina geschrieben:
> >It's just a warning, that you used a password for a block device that
> >doesn't require it. The device is opened successfully and should be
> >handled correctly (call the bdrv_dev_change_media_cb() ).
>
> Yep, IMO it's wo
On Mon, 17 Jun 2013 15:38:23 +0200
Pavel Hrdina wrote:
> On 17.6.2013 15:32, Luiz Capitulino wrote:
> > On Mon, 17 Jun 2013 15:25:24 +0200
> > Pavel Hrdina wrote:
> >
> >> On 17.6.2013 15:22, Luiz Capitulino wrote:
> >>> On Mon, 17 Jun 2013 14:33:10 +0200
> >>> Stefan Hajnoczi wrote:
> >>>
> >>
On 17.6.2013 15:32, Luiz Capitulino wrote:
On Mon, 17 Jun 2013 15:25:24 +0200
Pavel Hrdina wrote:
On 17.6.2013 15:22, Luiz Capitulino wrote:
On Mon, 17 Jun 2013 14:33:10 +0200
Stefan Hajnoczi wrote:
On Mon, Jun 17, 2013 at 11:46:19AM +0200, Pavel Hrdina wrote:
On 5.6.2013 15:23, Stefan Ha
On Mon, 17 Jun 2013 15:25:24 +0200
Pavel Hrdina wrote:
> On 17.6.2013 15:22, Luiz Capitulino wrote:
> > On Mon, 17 Jun 2013 14:33:10 +0200
> > Stefan Hajnoczi wrote:
> >
> >> On Mon, Jun 17, 2013 at 11:46:19AM +0200, Pavel Hrdina wrote:
> >>> On 5.6.2013 15:23, Stefan Hajnoczi wrote:
> On W
On 17.6.2013 15:22, Luiz Capitulino wrote:
On Mon, 17 Jun 2013 14:33:10 +0200
Stefan Hajnoczi wrote:
On Mon, Jun 17, 2013 at 11:46:19AM +0200, Pavel Hrdina wrote:
On 5.6.2013 15:23, Stefan Hajnoczi wrote:
On Wed, May 29, 2013 at 06:18:19PM +0200, Pavel Hrdina wrote:
@@ -1071,14 +1072,18 @@
On Mon, 17 Jun 2013 14:33:10 +0200
Stefan Hajnoczi wrote:
> On Mon, Jun 17, 2013 at 11:46:19AM +0200, Pavel Hrdina wrote:
> > On 5.6.2013 15:23, Stefan Hajnoczi wrote:
> > >On Wed, May 29, 2013 at 06:18:19PM +0200, Pavel Hrdina wrote:
> > >>@@ -1071,14 +1072,18 @@ static void
> > >>qmp_bdrv_open
On Mon, Jun 17, 2013 at 11:46:19AM +0200, Pavel Hrdina wrote:
> On 5.6.2013 15:23, Stefan Hajnoczi wrote:
> >On Wed, May 29, 2013 at 06:18:19PM +0200, Pavel Hrdina wrote:
> >>@@ -1071,14 +1072,18 @@ static void
> >>qmp_bdrv_open_encrypted(BlockDriverState *bs, const char *filename,
> >> i
On 5.6.2013 15:23, Stefan Hajnoczi wrote:
On Wed, May 29, 2013 at 06:18:19PM +0200, Pavel Hrdina wrote:
@@ -1071,14 +1072,18 @@ static void qmp_bdrv_open_encrypted(BlockDriverState
*bs, const char *filename,
if (password) {
if (bdrv_set_key(bs, password) < 0) {
On Wed, May 29, 2013 at 06:18:19PM +0200, Pavel Hrdina wrote:
> @@ -1071,14 +1072,18 @@ static void qmp_bdrv_open_encrypted(BlockDriverState
> *bs, const char *filename,
> if (password) {
> if (bdrv_set_key(bs, password) < 0) {
> error_set(errp, QERR_INVALID_
The bdrv_dev_change_media_cb() should be called only for eject and
change commands. We should call that function only if that command
is successful.
What this function does is that it calls the change_media_cb() and
also emit the QEVENT_DEVICE_TRAY_MOVED event.
Signed-off-by: Pavel Hrdina
---
b
15 matches
Mail list logo