Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Pavel Hrdina
On 17.6.2013 17:16, Kevin Wolf wrote: Am 17.06.2013 um 16:59 hat Luiz Capitulino geschrieben: On Mon, 17 Jun 2013 16:49:11 +0200 Kevin Wolf wrote: Am 17.06.2013 um 15:51 hat Luiz Capitulino geschrieben: On Mon, 17 Jun 2013 15:46:52 +0200 Kevin Wolf wrote: Am 17.06.2013 um 15:38 hat Pavel

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 16:49:11 +0200 Kevin Wolf wrote: > Am 17.06.2013 um 15:51 hat Luiz Capitulino geschrieben: > > On Mon, 17 Jun 2013 15:46:52 +0200 > > Kevin Wolf wrote: > > > > > Am 17.06.2013 um 15:38 hat Pavel Hrdina geschrieben: > > > > >It's just a warning, that you used a password f

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Kevin Wolf
Am 17.06.2013 um 16:59 hat Luiz Capitulino geschrieben: > On Mon, 17 Jun 2013 16:49:11 +0200 > Kevin Wolf wrote: > > > Am 17.06.2013 um 15:51 hat Luiz Capitulino geschrieben: > > > On Mon, 17 Jun 2013 15:46:52 +0200 > > > Kevin Wolf wrote: > > > > > > > Am 17.06.2013 um 15:38 hat Pavel Hrdina g

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Kevin Wolf
Am 17.06.2013 um 15:51 hat Luiz Capitulino geschrieben: > On Mon, 17 Jun 2013 15:46:52 +0200 > Kevin Wolf wrote: > > > Am 17.06.2013 um 15:38 hat Pavel Hrdina geschrieben: > > > >It's just a warning, that you used a password for a block device that > > > >doesn't require it. The device is

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 15:46:52 +0200 Kevin Wolf wrote: > Am 17.06.2013 um 15:38 hat Pavel Hrdina geschrieben: > > >It's just a warning, that you used a password for a block device that > > >doesn't require it. The device is opened successfully and should be > > >handled correctly (call

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Kevin Wolf
Am 17.06.2013 um 15:38 hat Pavel Hrdina geschrieben: > >It's just a warning, that you used a password for a block device that > >doesn't require it. The device is opened successfully and should be > >handled correctly (call the bdrv_dev_change_media_cb() ). > > Yep, IMO it's wo

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 15:38:23 +0200 Pavel Hrdina wrote: > On 17.6.2013 15:32, Luiz Capitulino wrote: > > On Mon, 17 Jun 2013 15:25:24 +0200 > > Pavel Hrdina wrote: > > > >> On 17.6.2013 15:22, Luiz Capitulino wrote: > >>> On Mon, 17 Jun 2013 14:33:10 +0200 > >>> Stefan Hajnoczi wrote: > >>> > >>

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Pavel Hrdina
On 17.6.2013 15:32, Luiz Capitulino wrote: On Mon, 17 Jun 2013 15:25:24 +0200 Pavel Hrdina wrote: On 17.6.2013 15:22, Luiz Capitulino wrote: On Mon, 17 Jun 2013 14:33:10 +0200 Stefan Hajnoczi wrote: On Mon, Jun 17, 2013 at 11:46:19AM +0200, Pavel Hrdina wrote: On 5.6.2013 15:23, Stefan Ha

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 15:25:24 +0200 Pavel Hrdina wrote: > On 17.6.2013 15:22, Luiz Capitulino wrote: > > On Mon, 17 Jun 2013 14:33:10 +0200 > > Stefan Hajnoczi wrote: > > > >> On Mon, Jun 17, 2013 at 11:46:19AM +0200, Pavel Hrdina wrote: > >>> On 5.6.2013 15:23, Stefan Hajnoczi wrote: > On W

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Pavel Hrdina
On 17.6.2013 15:22, Luiz Capitulino wrote: On Mon, 17 Jun 2013 14:33:10 +0200 Stefan Hajnoczi wrote: On Mon, Jun 17, 2013 at 11:46:19AM +0200, Pavel Hrdina wrote: On 5.6.2013 15:23, Stefan Hajnoczi wrote: On Wed, May 29, 2013 at 06:18:19PM +0200, Pavel Hrdina wrote: @@ -1071,14 +1072,18 @@

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 14:33:10 +0200 Stefan Hajnoczi wrote: > On Mon, Jun 17, 2013 at 11:46:19AM +0200, Pavel Hrdina wrote: > > On 5.6.2013 15:23, Stefan Hajnoczi wrote: > > >On Wed, May 29, 2013 at 06:18:19PM +0200, Pavel Hrdina wrote: > > >>@@ -1071,14 +1072,18 @@ static void > > >>qmp_bdrv_open

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Stefan Hajnoczi
On Mon, Jun 17, 2013 at 11:46:19AM +0200, Pavel Hrdina wrote: > On 5.6.2013 15:23, Stefan Hajnoczi wrote: > >On Wed, May 29, 2013 at 06:18:19PM +0200, Pavel Hrdina wrote: > >>@@ -1071,14 +1072,18 @@ static void > >>qmp_bdrv_open_encrypted(BlockDriverState *bs, const char *filename, > >> i

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Pavel Hrdina
On 5.6.2013 15:23, Stefan Hajnoczi wrote: On Wed, May 29, 2013 at 06:18:19PM +0200, Pavel Hrdina wrote: @@ -1071,14 +1072,18 @@ static void qmp_bdrv_open_encrypted(BlockDriverState *bs, const char *filename, if (password) { if (bdrv_set_key(bs, password) < 0) {

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-05 Thread Stefan Hajnoczi
On Wed, May 29, 2013 at 06:18:19PM +0200, Pavel Hrdina wrote: > @@ -1071,14 +1072,18 @@ static void qmp_bdrv_open_encrypted(BlockDriverState > *bs, const char *filename, > if (password) { > if (bdrv_set_key(bs, password) < 0) { > error_set(errp, QERR_INVALID_

[Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-05-29 Thread Pavel Hrdina
The bdrv_dev_change_media_cb() should be called only for eject and change commands. We should call that function only if that command is successful. What this function does is that it calls the change_media_cb() and also emit the QEVENT_DEVICE_TRAY_MOVED event. Signed-off-by: Pavel Hrdina --- b